Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 60916eecfe7bb999a9a73cea63855430d1b6dd79
https://github.com/WebKit/WebKit/commit/60916eecfe7bb999a9a73cea63855430d1b6dd79
Author: Elika Etemad <[email protected]>
Date: 2025-10-29 (Wed, 29 Oct 2025)
Changed paths:
A
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-area-alignment-inset-001-expected.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-area-alignment-inset-001-ref.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-area-alignment-inset-001.html
M
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-visibility-anchors-valid.tentative.html
M
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-visibility-anchors-visible-after-scroll-in-document.html
M
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-visibility-anchors-visible-after-scroll-in.html
M
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-visibility-anchors-visible-chained-004.html
M
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-visibility-anchors-visible-change-anchor.html
M
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-visibility-anchors-visible-change-css-visibility.html
M
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-visibility-anchors-visible-in-overflow-expected.html
M
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-visibility-anchors-visible-in-overflow-ref.html
M
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-visibility-anchors-visible-in-overflow.html
M
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-visibility-anchors-visible-with-position.html
M
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-visibility-remove-anchors-visible.html
M
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-visibility-remove-no-overflow.html
M Source/WebCore/rendering/PositionedLayoutConstraints.cpp
M Source/WebCore/rendering/PositionedLayoutConstraints.h
M Source/WebCore/rendering/RenderBox.cpp
M Source/WebCore/rendering/style/StyleSelfAlignmentData.h
Log Message:
-----------
position-area normal alignment with single auto inset aligns towards opposite
side
https://bugs.webkit.org/show_bug.cgi?id=301406
rdar://163317238
Reviewed by Alan Baradlay.
Updates PositionedLayoutConstraints::resolvePosition() to unsafe-align to the
non-auto inset when only one inset is auto.
See:
https://www.w3.org/TR/css-anchor-position/#position-area
https://github.com/w3c/csswg-drafts/issues/12512
Tests:
imported/w3c/web-platform-tests/css/css-anchor-position/position-area-alignment-inset-001-ref.html
imported/w3c/web-platform-tests/css/css-anchor-position/position-area-alignment-inset-001.html
*
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-area-alignment-inset-001-expected.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-area-alignment-inset-001-ref.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-area-alignment-inset-001.html:
Added.
Add new tests.
See https://github.com/web-platform-tests/wpt/pull/55722
*
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-visibility-anchors-valid.tentative.html:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-visibility-anchors-visible-after-scroll-in-document.html:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-visibility-anchors-visible-after-scroll-in.html:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-visibility-anchors-visible-chained-004.html:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-visibility-anchors-visible-change-anchor.html:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-visibility-anchors-visible-change-css-visibility.html:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-visibility-anchors-visible-in-overflow-expected.html:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-visibility-anchors-visible-in-overflow-ref.html:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-visibility-anchors-visible-in-overflow.html:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-visibility-anchors-visible-with-position.html:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-visibility-remove-anchors-visible.html:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-visibility-remove-no-overflow.html:
Modify existing tests that (unnecessarily) assumed the previous behavior.
See https://github.com/web-platform-tests/wpt/pull/55722
* Source/WebCore/rendering/PositionedLayoutConstraints.cpp:
(WebCore::PositionedLayoutConstraints::captureInsets):
Don't overwrite auto insets in our capture.
(WebCore::PositionedLayoutConstraints::resolvePosition const):
Check for position-area etc. directly in resolvePosition() instead.
(WebCore::PositionedLayoutConstraints::insetFitsContent const):
* Source/WebCore/rendering/PositionedLayoutConstraints.h:
* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::RenderBox::computeOutOfFlowPositionedLogicalWidthUsing const):
(WebCore::RenderBox::computeOutOfFlowPositionedLogicalHeightUsing const):
Update sizing code to not rely on insetBefore/After().isAuto().
* Source/WebCore/rendering/style/StyleSelfAlignmentData.h:
(WebCore::StyleSelfAlignmentData::isNormal const):
Add convenience method.
Canonical link: https://commits.webkit.org/302299@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
