Branch: refs/heads/webkitglib/2.50
Home: https://github.com/WebKit/WebKit
Commit: 62febe96851aabd2ca57c0bf14fcb76f8ae77a84
https://github.com/WebKit/WebKit/commit/62febe96851aabd2ca57c0bf14fcb76f8ae77a84
Author: Sihui Liu <[email protected]>
Date: 2025-10-24 (Fri, 24 Oct 2025)
Changed paths:
M Source/WebCore/platform/sql/SQLiteDatabase.cpp
M Source/WebCore/platform/sql/SQLiteDatabase.h
Log Message:
-----------
Cherry-pick 301962@main (242d212f7724).
https://bugs.webkit.org/show_bug.cgi?id=301253
Replace sqlite3_close with sqlite3_close_v2
https://bugs.webkit.org/show_bug.cgi?id=301253
rdar://163168512
Reviewed by Per Arne Vollan.
sqlite3_close_v2() never fails and it doesn't require all statements to be
manually finalized first -- it automatically
defers cleanup until resources are freed. This helps prevent resource leaks
compared to sqlite3_close (which requires
manual cleanup if the call fails).
This patch also removes an unused function in SQLiteDatabase.
* Source/WebCore/platform/sql/SQLiteDatabase.cpp:
(WebCore::SQLiteDatabase::open):
(WebCore::SQLiteDatabase::close):
(WebCore::WTF_GUARDED_BY_LOCK): Deleted.
(WebCore::SQLiteDatabase::setIsDatabaseOpeningForbidden): Deleted.
* Source/WebCore/platform/sql/SQLiteDatabase.h:
Canonical link: https://commits.webkit.org/301962@main
Canonical link: https://commits.webkit.org/298234.208@webkitglib/2.50
Commit: 515fa703d30482bd1ad816fddbdb0da830d2a8a8
https://github.com/WebKit/WebKit/commit/515fa703d30482bd1ad816fddbdb0da830d2a8a8
Author: Zak Ridouh <[email protected]>
Date: 2025-10-24 (Fri, 24 Oct 2025)
Changed paths:
A
LayoutTests/fast/css-grid-layout/grid-crash-area-range-for-out-of-flow-expected.txt
A
LayoutTests/fast/css-grid-layout/grid-crash-area-range-for-out-of-flow-no-text-expected.txt
A
LayoutTests/fast/css-grid-layout/grid-crash-area-range-for-out-of-flow-no-text.html
A
LayoutTests/fast/css-grid-layout/grid-crash-area-range-for-out-of-flow.html
M Source/WebCore/rendering/RenderBlock.cpp
Log Message:
-----------
Cherry-pick 301976@main (f64709780430).
https://bugs.webkit.org/show_bug.cgi?id=300354
[Layout] Fix crash in WebCore::RenderGrid::gridAreaRangeForOutOfFlow
https://bugs.webkit.org/show_bug.cgi?id=300354
rdar://161639703
Reviewed by Alan Baradlay.
Fix a crash in WebCore::RenderGrid::gridAreaRangeForOutOfFlow where we
haven't completed
in-flow placement and grid sizing yet, and so our positions vector doesn't
have valid values.
This aligns us closer with the spec, where only in flow children are
eligible for margin collapsing.
The root cause of this crash is we're attempting to do margin collapsing
with an out of flow child, but
we can only do this for in flow children.
[1] <https://drafts.csswg.org/css2/#collapsing-margins>
*
LayoutTests/fast/css-grid-layout/grid-crash-area-range-for-out-of-flow-expected.txt:
Added.
*
LayoutTests/fast/css-grid-layout/grid-crash-area-range-for-out-of-flow-no-text-expected.txt:
Added.
*
LayoutTests/fast/css-grid-layout/grid-crash-area-range-for-out-of-flow-no-text.html:
Added.
*
LayoutTests/fast/css-grid-layout/grid-crash-area-range-for-out-of-flow.html:
Added.
* Source/WebCore/rendering/RenderBlock.cpp:
(WebCore::RenderBlock::isSelfCollapsingBlock const):
Canonical link: https://commits.webkit.org/301976@main
Canonical link: https://commits.webkit.org/298234.209@webkitglib/2.50
Compare: https://github.com/WebKit/WebKit/compare/c4a00521c660...515fa703d304
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
