Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: af9ccb99d5c43b565881a3c2c0eb343594e7f66a
https://github.com/WebKit/WebKit/commit/af9ccb99d5c43b565881a3c2c0eb343594e7f66a
Author: Adrian Perez de Castro <[email protected]>
Date: 2025-10-24 (Fri, 24 Oct 2025)
Changed paths:
M Source/WebCore/Modules/webxr/WebXROpaqueFramebuffer.cpp
M Source/WebCore/platform/xr/PlatformXR.h
Log Message:
-----------
REGRESSION(302027@main): [WPE] Building for Android with WebXR enabled fails
https://bugs.webkit.org/show_bug.cgi?id=297900
Reviewed by Fujii Hironori.
Instead of the added ExternalTexture::isNull() method added in 302027@main,
define the boolean conversion operator for Cocoa. On Android this operator
gets picked directly from RefPtr<AHardwareBuffer>, and there was already
an implementation for non-Cocoa platforms.
* Source/WebCore/Modules/webxr/WebXROpaqueFramebuffer.cpp: Invert the
logic of checks to use the boolean conversion operator.
(WebCore::WebXROpaqueFramebuffer::reusableDisplayAttachments const):
(WebCore::WebXROpaqueFramebuffer::bindCompositorTexturesForDisplay):
* Source/WebCore/platform/xr/PlatformXR.h:
(PlatformXR::FrameData::ExternalTexture::operator bool const): Define the
operator for PLATFORM(COCOA).
(PlatformXR::FrameData::ExternalTexture::isNull const): Deleted, no longer
needed given that the boolean conversion operator is used in all cases.
Canonical link: https://commits.webkit.org/302109@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
