Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: c4180b46dd501e5166743900f5726302a52fc0bf
https://github.com/WebKit/WebKit/commit/c4180b46dd501e5166743900f5726302a52fc0bf
Author: Dan Glastonbury <[email protected]>
Date: 2025-10-22 (Wed, 22 Oct 2025)
Changed paths:
M Source/WebCore/Modules/webxr/WebXRSession.cpp
M Source/WebKit/UIProcess/XR/PlatformXRSystem.cpp
Log Message:
-----------
[WebXR] Test gardening after 300383@main
https://bugs.webkit.org/show_bug.cgi?id=301241
rdar://161189145
Reviewed by Mike Wyrzykowski.
The change in 300383@main is trying to be "a good citizen" by
unregistering observing visibility changes from WebXRSession::~WebXRSession.
This is causing an exception due to trying to accessing already
destructed hash map during DOMWindow destruction.
Since the observers are kept in a WeakHashSet there is no need to
unregister during WebXRSession::~WebXRSession.
In addtion, when obtaining permissions for an inline session, the
request is forwarded to PlatformXRCompositor, which only handles
immersiveVR sessions and asserts in Debug builds because the methods
are called in the wrong order.
Instead of forwarding the request to the compositor for inline mode,
all permissions are granted unconditionally.
* Source/WebCore/Modules/webxr/WebXRSession.cpp:
(WebCore::WebXRSession::~WebXRSession):
* Source/WebKit/UIProcess/XR/PlatformXRSystem.cpp:
(WebKit::PlatformXRSystem::requestPermissionOnSessionFeatures):
Canonical link: https://commits.webkit.org/301975@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
