Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: d3e95cb9a1e9e701bf8c074785e4c55e02353f00
https://github.com/WebKit/WebKit/commit/d3e95cb9a1e9e701bf8c074785e4c55e02353f00
Author: Anthony Tarbinian <[email protected]>
Date: 2025-10-22 (Wed, 22 Oct 2025)
Changed paths:
M Source/WebCore/html/HTMLMediaElement.cpp
Log Message:
-----------
[SaferCPP] Unchecked call arguments in HTMLMediaElement
https://bugs.webkit.org/show_bug.cgi?id=301107
rdar://163052480
Reviewed by Ryosuke Niwa.
Change call arguments in HTMLMediaElement.cpp to be checked.
Most of these changes are using protectedDocument() instead
of document(). The rest add usage of Ref/RefPtr/CheckedRef.
* Source/WebCore/html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::pauseAfterDetachedTask):
(WebCore::HTMLMediaElement::load):
(WebCore::HTMLMediaElement::loadResource):
(WebCore::HTMLMediaElement::isSafeToLoadURL const):
(WebCore::HTMLMediaElement::dispatchPlayPauseEventsIfNeedsQuirks):
(WebCore::HTMLMediaElement::updateShouldContinueAfterNeedKey):
(WebCore::HTMLMediaElement::mediaPlayerCachedKeyForKeyId const):
(WebCore::HTMLMediaElement::mediaPlayerKeyNeeded):
(WebCore::HTMLMediaElement::mediaPlayerMediaKeysStorageDirectory const):
(WebCore::HTMLMediaElement::mediaPlayerInitializationDataEncountered):
(WebCore::HTMLMediaElement::setAudioOutputDevice):
(WebCore::HTMLMediaElement::seekTask):
(WebCore::HTMLMediaElement::finishSeek):
(WebCore::HTMLMediaElement::controls const):
(WebCore::HTMLMediaElement::setVolume):
(WebCore::HTMLMediaElement::mediaPlayerDidReportGPUMemoryFootprint):
(WebCore::HTMLMediaElement::selectNextSourceChild):
(WebCore::HTMLMediaElement::updatePlayState):
(WebCore::HTMLMediaElement::resume):
(WebCore::HTMLMediaElement::elementIsHidden const):
(WebCore::HTMLMediaElement::exitFullscreen):
(WebCore::HTMLMediaElement::updateSleepDisabling):
(WebCore::HTMLMediaElement::mediaPlayerContentBoxRect const):
(WebCore::HTMLMediaElement::mediaPlayerCachedResourceLoader):
(WebCore::HTMLMediaElement::mediaPlayerCreateResourceLoader):
(WebCore::HTMLMediaElement::mediaPlayerEngineFailedToLoad):
(WebCore::HTMLMediaElement::removeBehaviorRestrictionsAfterFirstUserGesture):
(WebCore::HTMLMediaElement::setControllerJSProperty):
(WebCore::HTMLMediaElement::ensureMediaControls):
(WebCore::HTMLMediaElement::supportsSeeking const):
(WebCore::HTMLMediaElement::processingUserGestureForMedia const):
(WebCore::HTMLMediaElement::documentSecurityOrigin const):
(WebCore::HTMLMediaElement::updateMediaPlayer):
(WebCore::HTMLMediaElement::setShowingStats):
(WebCore::HTMLMediaElement::logTextTrackDiagnostics):
(WebCore::HTMLMediaElement::watchtimeTimerFired):
(WebCore::HTMLMediaElement::invalidateBufferingStopwatch):
(WebCore::HTMLMediaElement::limitedMatroskaSupportEnabled const):
Canonical link: https://commits.webkit.org/302006@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
