Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 742c0449ea780c8893b4930893d12f9e29152f6a
https://github.com/WebKit/WebKit/commit/742c0449ea780c8893b4930893d12f9e29152f6a
Author: Fujii Hironori <[email protected]>
Date: 2025-10-31 (Fri, 31 Oct 2025)
Changed paths:
M Tools/Scripts/webkitpy/port/monadodriver.py
M Tools/Scripts/webkitpy/port/monadodriver_unittest.py
M Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebXR.cpp
Log Message:
-----------
[GTK][WPE] Remove the WITH_OPENXR_RUNTIME environment variable
https://bugs.webkit.org/show_bug.cgi?id=301731
Reviewed by Adrian Perez de Castro.
The test runner scripts run-gtk-tests and run-wpe-tests automatically set the
WITH_OPENXR_RUNTIME env var if the monado-service command was found. And,
TestWebKitWebXR ran the tests only if the WITH_OPENXR_RUNTIME env var was set.
This didn't seem like a good idea. If the SDK happens to not contain the
monado-service command, the API tests are skipped. No one will realize the
problem. Additionally, if developers wanted to debug TestWebKitWebXR tests,
they had to set the WITH_OPENXR_RUNTIME env var before executing
TestWebKitWebXR without the test runner scripts.
* Tools/Scripts/webkitpy/port/monadodriver.py:
(MonadoDriver._setup_environ_for_test):
* Tools/Scripts/webkitpy/port/monadodriver_unittest.py:
(MonadoDriverTest.test_start):
* Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebXR.cpp:
(testWebKitWebXRLeaveImmersiveModeAndWaitUntilImmersiveModeChanged):
(testWebKitXRPermissionRequest):
Canonical link: https://commits.webkit.org/302385@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
