Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: b83fa6f790936a153f81eacb217e246a684c5da1
https://github.com/WebKit/WebKit/commit/b83fa6f790936a153f81eacb217e246a684c5da1
Author: Lily Spiniolas <[email protected]>
Date: 2025-10-31 (Fri, 31 Oct 2025)
Changed paths:
R
LayoutTests/platform/mac-sequoia-wk1/fast/forms/control-restrict-line-height-expected.txt
A
LayoutTests/platform/mac-sequoia/fast/forms/control-restrict-line-height-expected.txt
R
LayoutTests/platform/mac-sonoma-wk1/fast/forms/control-restrict-line-height-expected.txt
A
LayoutTests/platform/mac-sonoma/fast/forms/control-restrict-line-height-expected.txt
R
LayoutTests/platform/mac-wk1/fast/forms/control-restrict-line-height-expected.txt
R
LayoutTests/platform/mac-wk2/fast/forms/control-restrict-line-height-expected.txt
M LayoutTests/platform/mac/TestExpectations
M
LayoutTests/platform/mac/fast/forms/control-restrict-line-height-expected.txt
M Source/WebCore/rendering/cocoa/RenderThemeCocoa.h
M Source/WebCore/rendering/cocoa/RenderThemeCocoa.mm
M Source/WebCore/rendering/ios/RenderThemeIOS.mm
Log Message:
-----------
[macOS] WPT test
`html/rendering/replaced-elements/the-select-element/select-1-line-height.html`
is failing
https://bugs.webkit.org/show_bug.cgi?id=301611
rdar://162394818
Reviewed by Aditya Keerthi and Richard Robinson.
Enforce `line-height: normal` during style adjustment for native select
controls on macOS. This behavior matches iOS and is similar to what we
did prior to the form control refresh on macOS where we forced line-height
to `RenderStyle::initialLineHeight()`. This preserves a historic behavior
seen across browsers where `line-height` has no impact on select elements
which render as drop-down boxes.
Renamed `RenderThemeCocoa::paintInnerSpinButtonStyleForVectorBasedControls()`
to `RenderThemeCocoa::paintInnerSpinButtonForVectorBasedControls()`.
Tested by
`imported/w3c/web-platform-tests/html/rendering/replaced-elements/the-select-element/select-1-line-height.html`
*
LayoutTests/platform/mac-sequoia/fast/forms/control-restrict-line-height-expected.txt:
Renamed from
LayoutTests/platform/mac-sequoia-wk1/fast/forms/control-restrict-line-height-expected.txt.
*
LayoutTests/platform/mac-sonoma/fast/forms/control-restrict-line-height-expected.txt:
Renamed from
LayoutTests/platform/mac-sonoma-wk1/fast/forms/control-restrict-line-height-expected.txt.
*
LayoutTests/platform/mac-wk1/fast/forms/control-restrict-line-height-expected.txt:
Removed.
*
LayoutTests/platform/mac-wk2/fast/forms/control-restrict-line-height-expected.txt:
Removed.
* LayoutTests/platform/mac/TestExpectations:
* LayoutTests/platform/mac/fast/forms/control-restrict-line-height-expected.txt:
* Source/WebCore/rendering/cocoa/RenderThemeCocoa.h:
* Source/WebCore/rendering/cocoa/RenderThemeCocoa.mm:
(WebCore::RenderThemeCocoa::paintInnerSpinButtonForVectorBasedControls):
(WebCore::adjustSelectListButtonStyleForVectorBasedControls):
(WebCore::RenderThemeCocoa::adjustMenuListStyleForVectorBasedControls const):
(WebCore::RenderThemeCocoa::adjustMenuListButtonStyleForVectorBasedControls
const):
(WebCore::RenderThemeCocoa::paintInnerSpinButton):
(WebCore::RenderThemeCocoa::paintInnerSpinButtonStyleForVectorBasedControls):
Deleted.
* Source/WebCore/rendering/ios/RenderThemeIOS.mm:
(WebCore::adjustSelectListButtonStyle):
Canonical link: https://commits.webkit.org/302428@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
