Title: [113605] trunk
- Revision
- 113605
- Author
- [email protected]
- Date
- 2012-04-09 12:31:39 -0700 (Mon, 09 Apr 2012)
Log Message
[Qt][WK2] Fail to activate links after double tap gesture.
https://bugs.webkit.org/show_bug.cgi?id=83468
Patch by Zalan Bujtas <[email protected]> on 2012-04-09
Reviewed by Kenneth Rohde Christiansen.
.:
* ManualTests/link-activation-fails-after-double-tap-gesture.html: Added.
Source/WebKit2:
After a recognized double tap gesture, QtTapGestureRecognizer
gets stuck in the double-tap state. Only tapping outside of
the double tap radius cancels it.
Call reset() to set the default state back.
* UIProcess/qt/QtTapGestureRecognizer.cpp:
(WebKit::QtTapGestureRecognizer::recognize):
ManualTests/link-activation-fails-after-double-tap-gesture.html: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/ChangeLog (113604 => 113605)
--- trunk/ChangeLog 2012-04-09 19:28:42 UTC (rev 113604)
+++ trunk/ChangeLog 2012-04-09 19:31:39 UTC (rev 113605)
@@ -1,3 +1,12 @@
+2012-04-09 Zalan Bujtas <[email protected]>
+
+ [Qt][WK2] Fail to activate links after double tap gesture.
+ https://bugs.webkit.org/show_bug.cgi?id=83468
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ * ManualTests/link-activation-fails-after-double-tap-gesture.html: Added.
+
2012-04-09 Martin Robinson <[email protected]>
[soup] Crash while loading http://www.jusco.cn
Added: trunk/ManualTests/link-activation-fails-after-double-tap-gesture.html (0 => 113605)
--- trunk/ManualTests/link-activation-fails-after-double-tap-gesture.html (rev 0)
+++ trunk/ManualTests/link-activation-fails-after-double-tap-gesture.html 2012-04-09 19:31:39 UTC (rev 113605)
@@ -0,0 +1,7 @@
+<html>
+<body>
+ <p>This test verifies that after the double tap gesture, links can still be activated.</p>
+ <p>Double tap <span style='color: red'>here</span> and <a href="" style='background-color:green'>PASS</body></html>">try to activate this link</a> with single tap.</p>
+ <p>PASS if new page loads.</p>
+</body>
+</html>
Modified: trunk/Source/WebKit2/ChangeLog (113604 => 113605)
--- trunk/Source/WebKit2/ChangeLog 2012-04-09 19:28:42 UTC (rev 113604)
+++ trunk/Source/WebKit2/ChangeLog 2012-04-09 19:31:39 UTC (rev 113605)
@@ -1,3 +1,20 @@
+2012-04-09 Zalan Bujtas <[email protected]>
+
+ [Qt][WK2] Fail to activate links after double tap gesture.
+ https://bugs.webkit.org/show_bug.cgi?id=83468
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ After a recognized double tap gesture, QtTapGestureRecognizer
+ gets stuck in the double-tap state. Only tapping outside of
+ the double tap radius cancels it.
+ Call reset() to set the default state back.
+
+ * UIProcess/qt/QtTapGestureRecognizer.cpp:
+ (WebKit::QtTapGestureRecognizer::recognize):
+
+ ManualTests/link-activation-fails-after-double-tap-gesture.html: Added.
+
2012-04-07 Patrick Gansterer <[email protected]>
[CMake] Cleanup WTF include directories
Modified: trunk/Source/WebKit2/UIProcess/qt/QtTapGestureRecognizer.cpp (113604 => 113605)
--- trunk/Source/WebKit2/UIProcess/qt/QtTapGestureRecognizer.cpp 2012-04-09 19:28:42 UTC (rev 113604)
+++ trunk/Source/WebKit2/UIProcess/qt/QtTapGestureRecognizer.cpp 2012-04-09 19:31:39 UTC (rev 113605)
@@ -86,6 +86,7 @@
if (m_candidate == DoubleTapCandidate) {
m_eventHandler->handlePotentialSingleTapEvent(QTouchEvent::TouchPoint());
m_eventHandler->handleDoubleTapEvent(touchPoint);
+ reset();
}
break;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
