Title: [113607] trunk/Source/WebCore
- Revision
- 113607
- Author
- [email protected]
- Date
- 2012-04-09 12:46:56 -0700 (Mon, 09 Apr 2012)
Log Message
Correct some LayoutUnit misuse in FilterEffectRenderer, and RenderBlock
https://bugs.webkit.org/show_bug.cgi?id=83366
Reviewed by Eric Seidel.
Some more preparation of Render classes for FractionalLayoutUnits. See below for details
of each change.
No new tests. No change in behavior.
* rendering/FilterEffectRenderer.cpp:
(WebCore::FilterEffectRendererHelper::applyFilterEffect): Pixel snapping image rect before
drawing it.
* rendering/RenderBlock.cpp:
(WebCore::::string): Pixel snapping outputted values for debug.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (113606 => 113607)
--- trunk/Source/WebCore/ChangeLog 2012-04-09 19:31:56 UTC (rev 113606)
+++ trunk/Source/WebCore/ChangeLog 2012-04-09 19:46:56 UTC (rev 113607)
@@ -1,3 +1,21 @@
+2012-04-09 Levi Weintraub <[email protected]>
+
+ Correct some LayoutUnit misuse in FilterEffectRenderer, and RenderBlock
+ https://bugs.webkit.org/show_bug.cgi?id=83366
+
+ Reviewed by Eric Seidel.
+
+ Some more preparation of Render classes for FractionalLayoutUnits. See below for details
+ of each change.
+
+ No new tests. No change in behavior.
+
+ * rendering/FilterEffectRenderer.cpp:
+ (WebCore::FilterEffectRendererHelper::applyFilterEffect): Pixel snapping image rect before
+ drawing it.
+ * rendering/RenderBlock.cpp:
+ (WebCore::::string): Pixel snapping outputted values for debug.
+
2012-04-09 Shawn Singh <[email protected]>
[chromium] Fix layer sorting perspective w if w becomes negative
Modified: trunk/Source/WebCore/rendering/FilterEffectRenderer.cpp (113606 => 113607)
--- trunk/Source/WebCore/rendering/FilterEffectRenderer.cpp 2012-04-09 19:31:56 UTC (rev 113606)
+++ trunk/Source/WebCore/rendering/FilterEffectRenderer.cpp 2012-04-09 19:46:56 UTC (rev 113607)
@@ -403,7 +403,7 @@
LayoutRect destRect = filter->outputRect();
destRect.move(m_paintOffset.x(), m_paintOffset.y());
- m_savedGraphicsContext->drawImageBuffer(filter->output(), m_renderLayer->renderer()->style()->colorSpace(), destRect, CompositeSourceOver);
+ m_savedGraphicsContext->drawImageBuffer(filter->output(), m_renderLayer->renderer()->style()->colorSpace(), pixelSnappedIntRect(destRect), CompositeSourceOver);
return m_savedGraphicsContext;
}
Modified: trunk/Source/WebCore/rendering/RenderBlock.cpp (113606 => 113607)
--- trunk/Source/WebCore/rendering/RenderBlock.cpp 2012-04-09 19:31:56 UTC (rev 113606)
+++ trunk/Source/WebCore/rendering/RenderBlock.cpp 2012-04-09 19:46:56 UTC (rev 113607)
@@ -7369,7 +7369,7 @@
String ValueToString<RenderBlock::FloatingObject*>::string(const RenderBlock::FloatingObject* floatingObject)
{
- return String::format("%p (%dx%d %dx%d)", floatingObject, floatingObject->x(), floatingObject->y(), floatingObject->maxX(), floatingObject->maxY());
+ return String::format("%p (%dx%d %dx%d)", floatingObject, floatingObject->pixelSnappedX(), floatingObject->pixelSnappedY(), floatingObject->pixelSnappedMaxX(), floatingObject->pixelSnappedMaxY());
}
#endif
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
