Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 833e930831b0b2d0e8658ec69b469e6c775b4118
https://github.com/WebKit/WebKit/commit/833e930831b0b2d0e8658ec69b469e6c775b4118
Author: Tim Horton <[email protected]>
Date: 2025-11-05 (Wed, 05 Nov 2025)
Changed paths:
A
LayoutTests/fast/events/touch/ios/content-observation/visibility-toggles-off-and-back-expected.txt
A
LayoutTests/fast/events/touch/ios/content-observation/visibility-toggles-off-and-back.html
M Source/WebCore/page/ios/ContentChangeObserver.cpp
M Source/WebCore/page/ios/ContentChangeObserver.h
Log Message:
-----------
iPad: Google Search Suggestions require tapping twice to activate in Safari
https://bugs.webkit.org/show_bug.cgi?id=301995
rdar://162155695
Reviewed by Alan Baradlay.
When tapping on a Google Search suggestion, content change observation code
currently observes a single element transitioning from visible -> hidden ->
visible.
The second transition triggers a relevant content change, and invokes two-step
hover instead of synthesizing a click, despite not actually resulting in any
visible change on the page.
Test:
fast/events/touch/ios/content-observation/visibility-toggles-off-and-back.html
* Source/WebCore/page/ios/ContentChangeObserver.cpp:
(WebCore::ContentChangeObserver::reset):
(WebCore::ContentChangeObserver::elementDidBecomeVisible):
(WebCore::ContentChangeObserver::elementDidBecomeHidden):
* Source/WebCore/page/ios/ContentChangeObserver.h:
Keep track of the initial visibility state of any element that changes
visibility during a
given content change observation session; ignore any transitions to 'visible'
that
happen to elements that started out originally being visible.
*
LayoutTests/fast/events/touch/ios/content-observation/visibility-toggles-off-and-back-expected.txt:
Added.
*
LayoutTests/fast/events/touch/ios/content-observation/visibility-toggles-off-and-back.html:
Added.
Canonical link: https://commits.webkit.org/302590@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
