Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: e3cf8388bf12f51e3a7a7fafb6e4f3e3c419691a
https://github.com/WebKit/WebKit/commit/e3cf8388bf12f51e3a7a7fafb6e4f3e3c419691a
Author: Keita Nonaka <[email protected]>
Date: 2025-11-05 (Wed, 05 Nov 2025)
Changed paths:
M Source/JavaScriptCore/API/OpaqueJSString.cpp
M Source/JavaScriptCore/runtime/ArrayBuffer.cpp
M Source/JavaScriptCore/runtime/BufferMemoryHandle.cpp
M Source/JavaScriptCore/runtime/BufferMemoryHandle.h
M Source/JavaScriptCore/runtime/CommonIdentifiers.cpp
M Source/JavaScriptCore/runtime/ConsoleClient.cpp
M Source/JavaScriptCore/runtime/ConsoleClient.h
M Source/JavaScriptCore/runtime/ConstantMode.cpp
M Source/JavaScriptCore/runtime/ConstantMode.h
M Source/JavaScriptCore/runtime/DateConstructor.cpp
M Source/JavaScriptCore/runtime/DateConversion.cpp
M Source/JavaScriptCore/runtime/DateConversion.h
M Source/JavaScriptCore/runtime/DatePrototype.cpp
M Source/JavaScriptCore/runtime/DeletePropertySlot.h
M Source/JavaScriptCore/runtime/ErrorInstance.cpp
M Source/JavaScriptCore/runtime/ErrorInstance.h
M Source/JavaScriptCore/runtime/Exception.h
M Source/JavaScriptCore/runtime/ExceptionHelpers.cpp
M Source/JavaScriptCore/runtime/ExecutableBase.h
M Source/JavaScriptCore/runtime/Identifier.h
M Source/JavaScriptCore/runtime/VM.cpp
M Source/JavaScriptCore/wasm/WasmMemory.cpp
M Source/WebCore/bindings/js/JSDOMExceptionHandling.cpp
Log Message:
-----------
[JSC] Use more `enum class` for Safer C++
https://bugs.webkit.org/show_bug.cgi?id=295733
Reviewed by Darin Adler and Sosuke Suzuki.
This is a refactoring-only patch with no behavior changes.
Use `enum class` for `Kind`, `ArgumentRequirement`, `ConstantMode`,
`DateTimeFormat`, `Type`, `SourceTextWhereErrorOccurred`,
`StackCaptureAction`, `CompilationKind`, `EmptyIdentifierFlag` for Safer C++
[1].
[1]:
https://github.com/WebKit/WebKit/wiki/Safer-CPP-Guidelines#use-enum-classes-instead-of-old-style-enumerations
* Source/JavaScriptCore/API/OpaqueJSString.cpp:
(OpaqueJSString::identifier const):
* Source/JavaScriptCore/runtime/ArrayBuffer.cpp:
(JSC::tryAllocate):
* Source/JavaScriptCore/runtime/BufferMemoryHandle.cpp:
(JSC::BufferMemoryManager::tryAllocateFastMemory):
(JSC::BufferMemoryManager::tryAllocateGrowableBoundsCheckingMemory):
(JSC::BufferMemoryManager::tryAllocatePhysicalBytes):
* Source/JavaScriptCore/runtime/BufferMemoryHandle.h:
* Source/JavaScriptCore/runtime/CommonIdentifiers.cpp:
(JSC::CommonIdentifiers::CommonIdentifiers):
* Source/JavaScriptCore/runtime/ConsoleClient.cpp:
(JSC::ConsoleClient::internalMessageWithTypeAndLevel):
(JSC::ConsoleClient::logWithLevel):
(JSC::ConsoleClient::clear):
(JSC::ConsoleClient::dir):
(JSC::ConsoleClient::dirXML):
(JSC::ConsoleClient::table):
(JSC::ConsoleClient::trace):
(JSC::ConsoleClient::assertion):
(JSC::ConsoleClient::group):
(JSC::ConsoleClient::groupCollapsed):
(JSC::ConsoleClient::groupEnd):
* Source/JavaScriptCore/runtime/ConsoleClient.h:
(): Deleted.
* Source/JavaScriptCore/runtime/ConstantMode.cpp:
(WTF::printInternal):
* Source/JavaScriptCore/runtime/ConstantMode.h:
(JSC::modeForIsConstant):
(): Deleted.
* Source/JavaScriptCore/runtime/DateConstructor.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
* Source/JavaScriptCore/runtime/DateConversion.cpp:
(JSC::formatDateTime):
* Source/JavaScriptCore/runtime/DateConversion.h:
(): Deleted.
* Source/JavaScriptCore/runtime/DatePrototype.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
* Source/JavaScriptCore/runtime/DeletePropertySlot.h:
(JSC::DeletePropertySlot::DeletePropertySlot):
(JSC::DeletePropertySlot::setConfigurableMiss):
(JSC::DeletePropertySlot::setNonconfigurable):
(JSC::DeletePropertySlot::setHit):
(JSC::DeletePropertySlot::isCacheableDelete const):
(JSC::DeletePropertySlot::isDeleteHit const):
(JSC::DeletePropertySlot::isConfigurableDeleteMiss const):
(JSC::DeletePropertySlot::isNonconfigurable const):
(): Deleted.
* Source/JavaScriptCore/runtime/ErrorInstance.cpp:
(JSC::appendSourceToErrorMessage):
* Source/JavaScriptCore/runtime/ErrorInstance.h:
* Source/JavaScriptCore/runtime/Exception.h:
* Source/JavaScriptCore/runtime/ExceptionHelpers.cpp:
(JSC::defaultSourceAppender):
(JSC::notAFunctionSourceAppender):
(JSC::invalidParameterInSourceAppender):
(JSC::invalidParameterInstanceofSourceAppender):
(JSC::invalidPrototypeSourceAppender):
* Source/JavaScriptCore/runtime/ExecutableBase.h:
(): Deleted.
* Source/JavaScriptCore/runtime/Identifier.h:
(): Deleted.
* Source/JavaScriptCore/runtime/VM.cpp:
(JSC::VM::ensureTerminationException):
* Source/JavaScriptCore/wasm/WasmMemory.cpp:
* Source/WebCore/bindings/js/JSDOMExceptionHandling.cpp:
(WebCore::reportException):
Canonical link: https://commits.webkit.org/302621@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
