Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 49a8cc8d9856ae2e361eef1c05862c27a0c9ca96
https://github.com/WebKit/WebKit/commit/49a8cc8d9856ae2e361eef1c05862c27a0c9ca96
Author: Andy Estes <[email protected]>
Date: 2025-11-05 (Wed, 05 Nov 2025)
Changed paths:
M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm
Log Message:
-----------
REGRESSION(302506@main): Triggered assertions on visionOS Debug tester
https://bugs.webkit.org/show_bug.cgi?id=302013
rdar://164096712
Reviewed by Ryosuke Niwa.
As of 302223@main, subclasses of CanMakeCheckedPtr must be heap-allocated. If
they are not (and are
not exempted), CanMakeCheckedPtrBase::~CanMakeCheckedPtrBase crashes due to an
assertion failure.
Resolved this by heap-allocating
FullScreenWindowControllerVideoPresentationModelClient and storing
it in a unique_ptr in WKFullScreenWindowController.
* Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:
(-[WKFullScreenWindowController initWithWebView:]):
(-[WKFullScreenWindowController _isBestVideoInFullScreen]):
(-[WKFullScreenWindowController bestVideoFullscreenModeChanged]):
(-[WKFullScreenWindowController fullScreenViewControllerDidInvalidate:]):
(-[WKFullScreenWindowController
fullScreenViewController:bestVideoPresentationInterfaceDidChange:]):
Canonical link: https://commits.webkit.org/302631@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
