Title: [113624] trunk/Source/WebCore
- Revision
- 113624
- Author
- [email protected]
- Date
- 2012-04-09 14:46:55 -0700 (Mon, 09 Apr 2012)
Log Message
FrameData constructor zeroes all fields, causing ImageOrientation to be 0
https://bugs.webkit.org/show_bug.cgi?id=83416
Reviewed by Geoff Garen.
Reinstate SimpleClassVectorTraits on FrameData (which were removed by http://trac.webkit.org/changeset/113543)
with canInitializeWithMemset disabled, since two of the FrameData fields cannot be initialized to zero.
No new tests.
* platform/graphics/BitmapImage.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (113623 => 113624)
--- trunk/Source/WebCore/ChangeLog 2012-04-09 21:40:43 UTC (rev 113623)
+++ trunk/Source/WebCore/ChangeLog 2012-04-09 21:46:55 UTC (rev 113624)
@@ -1,3 +1,17 @@
+2012-04-09 Tim Horton <[email protected]>
+
+ FrameData constructor zeroes all fields, causing ImageOrientation to be 0
+ https://bugs.webkit.org/show_bug.cgi?id=83416
+
+ Reviewed by Geoff Garen.
+
+ Reinstate SimpleClassVectorTraits on FrameData (which were removed by http://trac.webkit.org/changeset/113543)
+ with canInitializeWithMemset disabled, since two of the FrameData fields cannot be initialized to zero.
+
+ No new tests.
+
+ * platform/graphics/BitmapImage.h:
+
2012-04-09 James Robinson <[email protected]>
[chromium] CCLayerTreeHost / WebLayerTreeView should be single ownership, not RefCounted
Modified: trunk/Source/WebCore/platform/graphics/BitmapImage.h (113623 => 113624)
--- trunk/Source/WebCore/platform/graphics/BitmapImage.h 2012-04-09 21:40:43 UTC (rev 113623)
+++ trunk/Source/WebCore/platform/graphics/BitmapImage.h 2012-04-09 21:46:55 UTC (rev 113624)
@@ -50,6 +50,12 @@
struct FrameData;
}
+namespace WTF {
+ template<> struct VectorTraits<WebCore::FrameData> : public SimpleClassVectorTraits {
+ static const bool canInitializeWithMemset = false; // Not all FrameData members initialize to 0.
+ };
+}
+
namespace WebCore {
template <typename T> class Timer;
@@ -59,6 +65,7 @@
// ================================================
struct FrameData {
+ WTF_MAKE_NONCOPYABLE(FrameData);
public:
FrameData()
: m_frame(0)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
