Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 44b22eb1df105edd3c9ce77888e752a3138919a7
https://github.com/WebKit/WebKit/commit/44b22eb1df105edd3c9ce77888e752a3138919a7
Author: Sam Weinig <[email protected]>
Date: 2025-11-07 (Fri, 07 Nov 2025)
Changed paths:
A
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-calc-margin-expected.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-calc-margin-ref.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-calc-margin.html
M Source/WebCore/rendering/GridLayoutFunctions.cpp
Log Message:
-----------
REGRESSION (300911@main): Card layout on archidekt.com is incorrect
https://bugs.webkit.org/show_bug.cgi?id=301873
Reviewed by Brandon Stewart and Sammy Gill.
Fixes logic in GridLayoutFunctions's `gridItemHasMargin` back to
what it was prior to 300911@main.
It had been considering a margin as being there (and is again) based on:
- YES: fixed and not 0
- YES: percentage and not 0
- YES: auto
- NO: calc()
300911@main changed the check to:
- YES: fixed and not 0
- YES: percentage and not 0
- YES: auto
- YES: calc()
Test: imported/w3c/web-platform-tests/css/css-grid/grid-calc-margin.html
*
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-calc-margin-expected.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-calc-margin-ref.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-calc-margin.html:
Added.
* Source/WebCore/rendering/GridLayoutFunctions.cpp:
Canonical link: https://commits.webkit.org/302744@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
