Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: aefa156346394392a734e686c81f99d59da0ad05
https://github.com/WebKit/WebKit/commit/aefa156346394392a734e686c81f99d59da0ad05
Author: Sam Weinig <[email protected]>
Date: 2025-11-10 (Mon, 10 Nov 2025)
Changed paths:
M Source/WebCore/Headers.cmake
M
Source/WebCore/SaferCPPExpectations/UncountedLambdaCapturesCheckerExpectations
M Source/WebCore/Sources.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
R Source/WebCore/css/CSSContentDistributionValue.cpp
R Source/WebCore/css/CSSContentDistributionValue.h
M Source/WebCore/css/CSSProperties.json
M Source/WebCore/css/CSSValue.cpp
M Source/WebCore/css/CSSValue.h
M Source/WebCore/css/MediaQueryList.cpp
M Source/WebCore/css/parser/CSSPropertyParserConsumer+Align.cpp
M Source/WebCore/layout/formattingContexts/flex/FlexLayout.cpp
M Source/WebCore/layout/formattingContexts/grid/GridFormattingContext.cpp
M Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp
M Source/WebCore/layout/integration/grid/LayoutIntegrationGridCoverage.cpp
M Source/WebCore/rendering/GridLayoutFunctions.cpp
M Source/WebCore/rendering/PositionedLayoutConstraints.cpp
M Source/WebCore/rendering/RenderBlockFlow.cpp
M Source/WebCore/rendering/RenderBox.cpp
M Source/WebCore/rendering/RenderFlexibleBox.cpp
M Source/WebCore/rendering/RenderGrid.cpp
M Source/WebCore/rendering/RenderInline.cpp
M Source/WebCore/rendering/RenderMenuList.cpp
M Source/WebCore/rendering/RenderTableCell.cpp
M Source/WebCore/rendering/RenderTableCellInlines.h
M Source/WebCore/rendering/cocoa/RenderThemeCocoa.mm
M Source/WebCore/rendering/style/RenderStyle.cpp
M Source/WebCore/rendering/style/RenderStyle.h
M Source/WebCore/rendering/style/RenderStyleInlines.h
M Source/WebCore/rendering/style/RenderStyleSetters.h
M Source/WebCore/rendering/style/StyleContentAlignmentData.h
M Source/WebCore/rendering/style/StyleMiscNonInheritedData.cpp
M Source/WebCore/rendering/style/StyleMiscNonInheritedData.h
M Source/WebCore/rendering/style/StyleRareNonInheritedData.h
M Source/WebCore/rendering/style/StyleSelfAlignmentData.h
M Source/WebCore/style/AnchorPositionEvaluator.cpp
M Source/WebCore/style/AnchorPositionEvaluator.h
M Source/WebCore/style/StyleAdjuster.cpp
M Source/WebCore/style/StyleBuilderConverter.h
M Source/WebCore/style/StyleExtractorConverter.h
M Source/WebCore/style/StyleExtractorSerializer.h
A Source/WebCore/style/values/align/StyleAlignContent.cpp
A Source/WebCore/style/values/align/StyleAlignContent.h
A Source/WebCore/style/values/align/StyleAlignItems.cpp
A Source/WebCore/style/values/align/StyleAlignItems.h
A Source/WebCore/style/values/align/StyleAlignSelf.cpp
A Source/WebCore/style/values/align/StyleAlignSelf.h
A Source/WebCore/style/values/align/StyleBaselineAlignmentPreference.h
A Source/WebCore/style/values/align/StyleJustifyContent.cpp
A Source/WebCore/style/values/align/StyleJustifyContent.h
A Source/WebCore/style/values/align/StyleJustifyItems.cpp
A Source/WebCore/style/values/align/StyleJustifyItems.h
A Source/WebCore/style/values/align/StyleJustifySelf.cpp
A Source/WebCore/style/values/align/StyleJustifySelf.h
A Source/WebCore/style/values/align/StyleLegacyPosition.h
A Source/WebCore/style/values/align/StyleOverflowPosition.h
M Source/WebCore/style/values/backgrounds/StyleLineWidth.cpp
Log Message:
-----------
[Style] Convert the 'align-*'/'justify-*' properties to strong style types
https://bugs.webkit.org/show_bug.cgi?id=302092#
Reviewed by Antti Koivisto and Darin Adler.
Converts the 'align-*'/'justify-*' alignment properties to use strong style
types.
As a lot of rendering code uses the existing alignment types,
`StyleSelfAlignmentData`
and `StyleContentAlignmentData`, the new type are resolved to the older types
for use.
This change also updates the parser to only use `CSSPrimitiveValue` and
`CSSValuePair`
for the CSS specified representation. The old `CSSContentDistributionValue`
made things
more complicated and didn't provide any concrete value. In addition, the parser
was
updated to use switch statements more, making it more in line with other parts
of the
parsing infrastructure. This introduces a bit of duplication, but overall makes
each
property more clear.
* Source/WebCore/Headers.cmake:
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/css/CSSContentDistributionValue.cpp: Removed.
* Source/WebCore/css/CSSContentDistributionValue.h: Removed.
* Source/WebCore/css/CSSProperties.json:
* Source/WebCore/css/CSSValue.cpp:
* Source/WebCore/css/CSSValue.h:
* Source/WebCore/css/parser/CSSPropertyParserConsumer+Align.cpp:
* Source/WebCore/layout/formattingContexts/flex/FlexLayout.cpp:
* Source/WebCore/layout/formattingContexts/grid/GridFormattingContext.cpp:
* Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp:
* Source/WebCore/layout/integration/grid/LayoutIntegrationGridCoverage.cpp:
* Source/WebCore/rendering/GridLayoutFunctions.cpp:
* Source/WebCore/rendering/PositionedLayoutConstraints.cpp:
* Source/WebCore/rendering/RenderBlockFlow.cpp:
* Source/WebCore/rendering/RenderBox.cpp:
* Source/WebCore/rendering/RenderFlexibleBox.cpp:
* Source/WebCore/rendering/RenderGrid.cpp:
* Source/WebCore/rendering/RenderInline.cpp:
* Source/WebCore/rendering/RenderMenuList.cpp:
* Source/WebCore/rendering/RenderTableCell.cpp:
* Source/WebCore/rendering/RenderTableCellInlines.h:
* Source/WebCore/rendering/cocoa/RenderThemeCocoa.mm:
* Source/WebCore/rendering/style/RenderStyle.cpp:
* Source/WebCore/rendering/style/RenderStyle.h:
* Source/WebCore/rendering/style/RenderStyleInlines.h:
* Source/WebCore/rendering/style/RenderStyleSetters.h:
* Source/WebCore/rendering/style/StyleContentAlignmentData.h:
* Source/WebCore/rendering/style/StyleMiscNonInheritedData.cpp:
* Source/WebCore/rendering/style/StyleMiscNonInheritedData.h:
* Source/WebCore/rendering/style/StyleRareNonInheritedData.h:
* Source/WebCore/rendering/style/StyleSelfAlignmentData.h:
* Source/WebCore/style/AnchorPositionEvaluator.cpp:
* Source/WebCore/style/StyleAdjuster.cpp:
* Source/WebCore/style/StyleBuilderConverter.h:
* Source/WebCore/style/StyleExtractorConverter.h:
* Source/WebCore/style/StyleExtractorSerializer.h:
* Source/WebCore/style/values/align/StyleAlignContent.cpp: Added.
* Source/WebCore/style/values/align/StyleAlignContent.h: Added.
* Source/WebCore/style/values/align/StyleAlignItems.cpp: Added.
* Source/WebCore/style/values/align/StyleAlignItems.h: Added.
* Source/WebCore/style/values/align/StyleAlignSelf.cpp: Added.
* Source/WebCore/style/values/align/StyleAlignSelf.h: Added.
* Source/WebCore/style/values/align/StyleBaselineAlignmentPreference.h: Added.
* Source/WebCore/style/values/align/StyleJustifyContent.cpp: Added.
* Source/WebCore/style/values/align/StyleJustifyContent.h: Added.
* Source/WebCore/style/values/align/StyleJustifyItems.cpp: Added.
* Source/WebCore/style/values/align/StyleJustifyItems.h: Added.
* Source/WebCore/style/values/align/StyleJustifySelf.cpp: Added.
* Source/WebCore/style/values/align/StyleJustifySelf.h: Added.
* Source/WebCore/style/values/align/StyleLegacyPosition.h: Added.
* Source/WebCore/style/values/align/StyleOverflowPosition.h: Added.
* Source/WebCore/style/values/backgrounds/StyleLineWidth.cpp:
Canonical link: https://commits.webkit.org/302800@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
