Diff
Modified: trunk/ChangeLog (113635 => 113636)
--- trunk/ChangeLog 2012-04-09 22:44:18 UTC (rev 113635)
+++ trunk/ChangeLog 2012-04-09 22:49:43 UTC (rev 113636)
@@ -1,3 +1,15 @@
+2012-04-09 Dale Curtis <[email protected]>
+
+ Remove unworkable video-buffering-repaints-controls test.
+ https://bugs.webkit.org/show_bug.cgi?id=83097
+
+ Replaces the automated test for progress bar repaints during buffering
+ with a manual test entry.
+
+ Reviewed by Eric Carlson.
+
+ * ManualTests/media-controls.html:
+
2012-04-09 Ming Xie <[email protected]>
[BlackBerry] Allow simulator to use GLES2 acceleration
Modified: trunk/LayoutTests/ChangeLog (113635 => 113636)
--- trunk/LayoutTests/ChangeLog 2012-04-09 22:44:18 UTC (rev 113635)
+++ trunk/LayoutTests/ChangeLog 2012-04-09 22:49:43 UTC (rev 113636)
@@ -1,3 +1,33 @@
+2012-04-09 Dale Curtis <[email protected]>
+
+ Remove unworkable video-buffering-repaints-controls test.
+ https://bugs.webkit.org/show_bug.cgi?id=83097
+
+ Test has been broken in one way or another for some time now. I've
+ approached multiple people about possible solutions, but nothing ends
+ up being stable.
+
+ After discussion with fischman and trying a couple more solutions
+ today, we decided the best course of action is to remove the test.
+
+ Reviewed by Eric Carlson.
+
+ * http/tests/media/video-buffering-repaints-controls-expected.txt: Removed.
+ * http/tests/media/video-buffering-repaints-controls.html: Removed.
+ * platform/chromium-linux/http/tests/media/video-buffering-repaints-controls-expected.png: Removed.
+ * platform/chromium-mac-leopard/http/tests/media/video-buffering-repaints-controls-expected.png: Removed.
+ * platform/chromium-mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.png: Removed.
+ * platform/chromium-mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.txt: Removed.
+ * platform/chromium-mac/http/tests/media/video-buffering-repaints-controls-expected.png: Removed.
+ * platform/chromium-win/http/tests/media/video-buffering-repaints-controls-expected.png: Removed.
+ * platform/chromium/test_expectations.txt:
+ * platform/efl/Skipped:
+ * platform/gtk/Skipped:
+ * platform/mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.png: Removed.
+ * platform/mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.txt: Removed.
+ * platform/mac/Skipped:
+ * platform/mac/test_expectations.txt:
+
2012-04-09 Sheriff Bot <[email protected]>
Unreviewed, rolling out r113613.
Deleted: trunk/LayoutTests/http/tests/media/video-buffering-repaints-controls-expected.txt (113635 => 113636)
--- trunk/LayoutTests/http/tests/media/video-buffering-repaints-controls-expected.txt 2012-04-09 22:44:18 UTC (rev 113635)
+++ trunk/LayoutTests/http/tests/media/video-buffering-repaints-controls-expected.txt 2012-04-09 22:49:43 UTC (rev 113636)
@@ -1,4 +0,0 @@
-Test that media controls repaint correctly during paused states when new data is buffered.
-
-
-
Deleted: trunk/LayoutTests/http/tests/media/video-buffering-repaints-controls.html (113635 => 113636)
--- trunk/LayoutTests/http/tests/media/video-buffering-repaints-controls.html 2012-04-09 22:44:18 UTC (rev 113635)
+++ trunk/LayoutTests/http/tests/media/video-buffering-repaints-controls.html 2012-04-09 22:49:43 UTC (rev 113636)
@@ -1,34 +0,0 @@
-<html>
- <head>
- <script src=""
- <script>
- function start() {
- if (window.layoutTestController) {
- layoutTestController.dumpAsText(true);
- layoutTestController.waitUntilDone();
- }
-
- var video = document.querySelector('video');
-
- video.addEventListener('progress', function(event) {
- layoutTestController.display();
- }, false);
-
- video.addEventListener('suspend', function(event) {
- layoutTestController.notifyDone();
- }, false);
-
- var mediaFile = findMediaFile("video", "resources/test");
- var mimeType = mimeTypeForFile(mediaFile);
-
- // Don't actually play since we're testing via an image diff.
- video.src = '' + mediaFile + '&throttle=80&type=' + mimeType
- }
- </script>
- </head>
-
- <body _onload_="start();">
- <p>Test that media controls repaint correctly during paused states when new data is buffered.</p>
- <video controls preload></video><br/>
- </body>
-</html>
Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (113635 => 113636)
--- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-04-09 22:44:18 UTC (rev 113635)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-04-09 22:49:43 UTC (rev 113636)
@@ -3265,9 +3265,6 @@
BUGV81900 SLOW LINUX DEBUG : inspector/debugger/watch-expressions-panel-switch.html = PASS CRASH
BUGV81900 SLOW LINUX DEBUG : inspector/debugger/debugger-breakpoints-not-activated-on-reload.html = PASS CRASH
-// New test, image results added but it is timing out on Leopard.
-BUGWK75570 WIN LINUX : http/tests/media/video-buffering-repaints-controls.html = IMAGE
-
// New reftest failing on Win7.
BUGWK76050 WIN7 : fast/text/font-kerning.html = IMAGE
Deleted: trunk/LayoutTests/platform/chromium-linux/http/tests/media/video-buffering-repaints-controls-expected.png
(Binary files differ)
Deleted: trunk/LayoutTests/platform/chromium-mac/http/tests/media/video-buffering-repaints-controls-expected.png
(Binary files differ)
Deleted: trunk/LayoutTests/platform/chromium-mac-leopard/http/tests/media/video-buffering-repaints-controls-expected.png
(Binary files differ)
Deleted: trunk/LayoutTests/platform/chromium-mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.png
(Binary files differ)
Deleted: trunk/LayoutTests/platform/chromium-mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.txt (113635 => 113636)
--- trunk/LayoutTests/platform/chromium-mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.txt 2012-04-09 22:44:18 UTC (rev 113635)
+++ trunk/LayoutTests/platform/chromium-mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.txt 2012-04-09 22:49:43 UTC (rev 113636)
@@ -1,4 +0,0 @@
-Test that media controls repaint correctly during paused states when new data is buffered.
-
-
-
Deleted: trunk/LayoutTests/platform/chromium-win/http/tests/media/video-buffering-repaints-controls-expected.png
(Binary files differ)
Modified: trunk/LayoutTests/platform/efl/Skipped (113635 => 113636)
--- trunk/LayoutTests/platform/efl/Skipped 2012-04-09 22:44:18 UTC (rev 113635)
+++ trunk/LayoutTests/platform/efl/Skipped 2012-04-09 22:49:43 UTC (rev 113636)
@@ -2404,7 +2404,6 @@
http/tests/loading/state-object-security-exception.html
http/tests/media/remove-while-loading.html
http/tests/media/video-buffered.html
-http/tests/media/video-buffering-repaints-controls.html
http/tests/media/video-cancel-load.html
http/tests/media/video-cookie.html
http/tests/media/video-error-abort.html
Modified: trunk/LayoutTests/platform/gtk/Skipped (113635 => 113636)
--- trunk/LayoutTests/platform/gtk/Skipped 2012-04-09 22:44:18 UTC (rev 113635)
+++ trunk/LayoutTests/platform/gtk/Skipped 2012-04-09 22:49:43 UTC (rev 113636)
@@ -1526,9 +1526,6 @@
fast/events/clear-drag-state.html
fast/events/clear-edit-drag-state.html
-# https://bugs.webkit.org/show_bug.cgi?id=77019
-http/tests/media/video-buffering-repaints-controls.html
-
# https://bugs.webkit.org/show_bug.cgi?id=77413
fast/parser/nested-fragment-parser-crash.html
Modified: trunk/LayoutTests/platform/mac/Skipped (113635 => 113636)
--- trunk/LayoutTests/platform/mac/Skipped 2012-04-09 22:44:18 UTC (rev 113635)
+++ trunk/LayoutTests/platform/mac/Skipped 2012-04-09 22:49:43 UTC (rev 113636)
@@ -611,7 +611,6 @@
# Media tests that time out unexpectedly
# https://bugs.webkit.org/show_bug.cgi?id=81604
-http/tests/media/video-buffering-repaints-controls.html
http/tests/media/video-useragent.html
media/audio-garbage-collect.html
Modified: trunk/LayoutTests/platform/mac/test_expectations.txt (113635 => 113636)
--- trunk/LayoutTests/platform/mac/test_expectations.txt 2012-04-09 22:44:18 UTC (rev 113635)
+++ trunk/LayoutTests/platform/mac/test_expectations.txt 2012-04-09 22:49:43 UTC (rev 113636)
@@ -149,9 +149,6 @@
BUGWK74888 : fast/repaint/table-section-repaint.html = TEXT
BUGWK74888 : fast/table/frame-and-rules.html = TEXT
-// New test, needs image results added.
-BUGWK75570 : http/tests/media/video-buffering-repaints-controls.html = IMAGE
-
// Rebaseline required after bug 74874
BUGWK74874 : fast/table/027.html = TEXT
BUGWK74874 : fast/table/027-vertical.html = TEXT
Deleted: trunk/LayoutTests/platform/mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.png
(Binary files differ)
Deleted: trunk/LayoutTests/platform/mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.txt (113635 => 113636)
--- trunk/LayoutTests/platform/mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.txt 2012-04-09 22:44:18 UTC (rev 113635)
+++ trunk/LayoutTests/platform/mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.txt 2012-04-09 22:49:43 UTC (rev 113636)
@@ -1,37 +0,0 @@
-layer at (0,0) size 800x600
- RenderView at (0,0) size 800x600
-layer at (0,0) size 800x600
- RenderBlock {HTML} at (0,0) size 800x600
- RenderBody {BODY} at (8,8) size 784x584
- RenderBlock {P} at (0,0) size 784x18
- RenderText {#text} at (0,0) size 562x18
- text run at (0,0) width 562: "Test that media controls repaint correctly during paused states when new data is buffered."
- RenderBlock (anonymous) at (0,34) size 784x240
- RenderBR {BR} at (320,240) size 0x0
-layer at (8,42) size 320x240
- RenderVideo {VIDEO} at (0,0) size 320x240
-layer at (8,42) size 320x240
- RenderBlock (relative positioned) {DIV} at (0,0) size 320x240
-layer at (8,257) size 320x25
- RenderDeprecatedFlexibleBox (positioned) {DIV} at (0,215) size 320x25
- RenderButton {INPUT} at (6,3) size 18x18
- RenderButton {INPUT} at (32,4) size 16x16
- RenderDeprecatedFlexibleBox {DIV} at (49,5) size 216x15
- RenderSlider {INPUT} at (45,2) size 126x13
- RenderDeprecatedFlexibleBox {DIV} at (0,0) size 126x13
- RenderBlock {DIV} at (0,2) size 116x8
- RenderBlock {DIV} at (116,2) size 10x8
- RenderButton {INPUT} at (297,4) size 16x16
- RenderButton {INPUT} at (267,6) size 14x12
-layer at (57,264) size 45x11
- RenderDeprecatedFlexibleBox {DIV} at (0,2) size 45x11 [color=#FFFFFF]
- RenderBlock (anonymous) at (9,0) size 26x11
- RenderText {#text} at (0,0) size 26x11
- text run at (0,0) width 26: "00:00"
-layer at (228,264) size 45x11
- RenderDeprecatedFlexibleBox {DIV} at (171,2) size 45x11 [color=#FFFFFF]
- RenderBlock (anonymous) at (7,0) size 31x11
- RenderText {#text} at (0,0) size 31x11
- text run at (0,0) width 31: "-00:06"
-layer at (102,266) size 10x8
- RenderBlock (relative positioned) {DIV} at (0,0) size 10x8
Modified: trunk/ManualTests/media-controls.html (113635 => 113636)
--- trunk/ManualTests/media-controls.html 2012-04-09 22:44:18 UTC (rev 113635)
+++ trunk/ManualTests/media-controls.html 2012-04-09 22:49:43 UTC (rev 113636)
@@ -192,6 +192,16 @@
title: 'Audio with no source',
description: 'Should have "Rewind" and "Play" buttons. Should not blink/twitch if reloaded.',
html: '<audio controls></audio>'
+},
+'controls-buffer-update': {
+ title: 'Buffer progress bar updates',
+ description: '<p>The buffer progress bar should continue to update prior to video playback.</p>' +
+ '<p>Verify the progress bar representing the amount of video buffered continues to ' +
+ 'update prior to video playback. Keep the mouse pointer off the progress bar during this check ' +
+ 'as movement over the control will trigger a repaint which invalidates the test.</p><p>' +
+ 'It\'s expected that the video may stop buffering before the entire video is loaded.</p>',
+ html: '<video controls src="" +
+ '?prevent_caching=' + new Date().getTime() + '"></video>'
}
};
