Title: [113643] trunk/Source/WebCore
- Revision
- 113643
- Author
- [email protected]
- Date
- 2012-04-09 16:58:56 -0700 (Mon, 09 Apr 2012)
Log Message
Make CSSValueID's into an enum instead of a collection of integers.
https://bugs.webkit.org/show_bug.cgi?id=83246
Reviewed by Simon Fraser.
This patch simply converts the list of integers into an enum.
Follow-up patches will then convert existing code that uses integers to use the new enum.
No new tests / no functionality changed.
* css/makevalues.pl:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (113642 => 113643)
--- trunk/Source/WebCore/ChangeLog 2012-04-09 23:54:12 UTC (rev 113642)
+++ trunk/Source/WebCore/ChangeLog 2012-04-09 23:58:56 UTC (rev 113643)
@@ -1,3 +1,17 @@
+2012-04-09 Luke Macpherson <[email protected]>
+
+ Make CSSValueID's into an enum instead of a collection of integers.
+ https://bugs.webkit.org/show_bug.cgi?id=83246
+
+ Reviewed by Simon Fraser.
+
+ This patch simply converts the list of integers into an enum.
+ Follow-up patches will then convert existing code that uses integers to use the new enum.
+
+ No new tests / no functionality changed.
+
+ * css/makevalues.pl:
+
2012-04-09 Sheriff Bot <[email protected]>
Unreviewed, rolling out r113609.
Modified: trunk/Source/WebCore/css/makevalues.pl (113642 => 113643)
--- trunk/Source/WebCore/css/makevalues.pl 2012-04-09 23:54:12 UTC (rev 113642)
+++ trunk/Source/WebCore/css/makevalues.pl 2012-04-09 23:58:56 UTC (rev 113643)
@@ -130,7 +130,8 @@
namespace WebCore {
-const int CSSValueInvalid = 0;
+enum CSSValueID {
+ CSSValueInvalid = 0,
EOF
my $i = 1;
@@ -138,12 +139,14 @@
foreach my $name (@names) {
my $id = $name;
$id =~ s/(^[^-])|-(.)/uc($1||$2)/ge;
- print HEADER "const int CSSValue" . $id . " = " . $i . ";\n";
+ print HEADER " CSSValue" . $id . " = " . $i . ",\n";
$i = $i + 1;
if (length($name) > $maxLen) {
$maxLen = length($name);
}
}
+
+print HEADER "};\n\n";
print HEADER "const int numCSSValueKeywords = " . $i . ";\n";
print HEADER "const size_t maxCSSValueKeywordLength = " . $maxLen . ";\n";
print HEADER << "EOF";
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
