Title: [113648] trunk/Source/_javascript_Core
Revision
113648
Author
[email protected]
Date
2012-04-09 18:00:40 -0700 (Mon, 09 Apr 2012)

Log Message

Classic interpreter's GC hooks shouldn't attempt to scan instructions for code blocks that
are currently being generated
https://bugs.webkit.org/show_bug.cgi?id=83531
<rdar://problem/11215200>

Reviewed by Gavin Barraclough.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::stronglyVisitStrongReferences):

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (113647 => 113648)


--- trunk/Source/_javascript_Core/ChangeLog	2012-04-10 00:44:20 UTC (rev 113647)
+++ trunk/Source/_javascript_Core/ChangeLog	2012-04-10 01:00:40 UTC (rev 113648)
@@ -1,5 +1,17 @@
 2012-04-09  Filip Pizlo  <[email protected]>
 
+        Classic interpreter's GC hooks shouldn't attempt to scan instructions for code blocks that
+        are currently being generated
+        https://bugs.webkit.org/show_bug.cgi?id=83531
+        <rdar://problem/11215200>
+
+        Reviewed by Gavin Barraclough.
+
+        * bytecode/CodeBlock.cpp:
+        (JSC::CodeBlock::stronglyVisitStrongReferences):
+
+2012-04-09  Filip Pizlo  <[email protected]>
+
         Unreviewed, modernize and clean up uses of ARM assembly mnemonics in inline asm blocks.
 
         * dfg/DFGOperations.cpp:

Modified: trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp (113647 => 113648)


--- trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp	2012-04-10 00:44:20 UTC (rev 113647)
+++ trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp	2012-04-10 01:00:40 UTC (rev 113648)
@@ -1926,7 +1926,7 @@
     for (size_t i = 0; i < m_functionDecls.size(); ++i)
         visitor.append(&m_functionDecls[i]);
 #if ENABLE(CLASSIC_INTERPRETER)
-    if (m_globalData->interpreter->classicEnabled()) {
+    if (m_globalData->interpreter->classicEnabled() && !!numberOfInstructions()) {
         for (size_t size = m_propertyAccessInstructions.size(), i = 0; i < size; ++i)
             visitStructures(visitor, &instructions()[m_propertyAccessInstructions[i]]);
         for (size_t size = m_globalResolveInstructions.size(), i = 0; i < size; ++i)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to