Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 8a05c73a1d696f17d7713d7886713ed5b2d9bbde
https://github.com/WebKit/WebKit/commit/8a05c73a1d696f17d7713d7886713ed5b2d9bbde
Author: Antoine Quint <[email protected]>
Date: 2025-11-19 (Wed, 19 Nov 2025)
Changed paths:
A
LayoutTests/webanimations/pause-after-switching-to-finite-timeline-expected.txt
A LayoutTests/webanimations/pause-after-switching-to-finite-timeline.html
M Source/WebCore/animation/WebAnimation.cpp
Log Message:
-----------
[WebKit][Main+SU] [bcdfa3892054a35c] ASAN_TRAP |
WebCore::WebAnimationTime::approximatelyLessThan;
WebCore::AnimationEffectTiming::getBasicTiming;
WebCore::AnimationEffect::getBasicTiming
https://bugs.webkit.org/show_bug.cgi?id=298869
rdar://160116687
Reviewed by Anne van Kesteren.
As part of 294049@main we started storing a "pending start time" for each
animation which we would
set to be the start time when marking the animation as ready. When switching
from a monotonic to a
progress-based timeline, we may be in a situation where that "pending start
time" was recorded based
on the monotonic timeline, and if the animation is paused with a monotonic
"pending start time" then
we will try to run some logic based on both monotonic and progress-based times
in `WebAnimation::runPendingPauseTask()`.
To address this, we reset the "pending start time" when switching timelines,
which makes sense regardless
of the type of timeline we're dealing with.
*
LayoutTests/webanimations/pause-after-switching-to-finite-timeline-expected.txt:
Added.
* LayoutTests/webanimations/pause-after-switching-to-finite-timeline.html:
Added.
* Source/WebCore/animation/WebAnimation.cpp:
(WebCore::WebAnimation::setTimelineInternal):
Originally-landed-as: 297297.417@safari-7622-branch (9a1fcd2847a2).
rdar://164214430
Canonical link: https://commits.webkit.org/303264@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
