Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 0f137772c935fe6f8d188ab40bceefe731c719e2
https://github.com/WebKit/WebKit/commit/0f137772c935fe6f8d188ab40bceefe731c719e2
Author: Geoffrey Garen <[email protected]>
Date: 2025-11-19 (Wed, 19 Nov 2025)
Changed paths:
M Source/JavaScriptCore/heap/MachineStackMarker.h
M Source/WTF/wtf/Lock.h
M Source/WTF/wtf/ParkingLot.cpp
M Source/WTF/wtf/ThreadGroup.cpp
M Source/WTF/wtf/ThreadGroup.h
M Source/WTF/wtf/ThreadSafeWeakHashSet.h
M Source/WTF/wtf/ThreadSafeWeakPtr.h
M Source/WTF/wtf/Threading.cpp
M Source/WTF/wtf/Threading.h
M Source/WTF/wtf/WordLock.h
M Source/WTF/wtf/linux/RealTimeThreads.h
M Source/WTF/wtf/threads/Signals.cpp
M Tools/TestWebKitAPI/Tests/WTF/ThreadGroup.cpp
Log Message:
-----------
Use ThreadSafeWeakHashSet for Thread
https://bugs.webkit.org/show_bug.cgi?id=302743
rdar://165000250
Reviewed by Marcus Plutowski.
Because SaferCPP objects to HashMap<Thread*, ...>.
Re-landed 258267@main now that 287313@main has fixed the bugs that originally
blocked the conversion to ThreadSafeWeakHashSet.
Updated clients to use Ref/RefPtr instead of std::shared_ptr.
Also changed ThreadSafeWeakHashSet and
ThreadSafeRefCountedAndCanMakeThreadSafeWeakPtr
to use WordLock instead of Lock. Thread and ThreadGroup require a lock that can
be used without access to TLS.
Also adopted WTF_CAPABILITY_LOCK annotations for WordLock, so that we don't
regress thread-safety analysis coverage by switching to WordLock. This required
suppressing some existing inconsistencies (which are fine, just not verifiable).
Canonical link: https://commits.webkit.org/303280@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
