Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 140d0233804ebc06297064c1b14e59d15a70a9a0
https://github.com/WebKit/WebKit/commit/140d0233804ebc06297064c1b14e59d15a70a9a0
Author: Darryl Parkinson <[email protected]>
Date: 2025-11-19 (Wed, 19 Nov 2025)
Changed paths:
M Source/WebKit/NetworkProcess/NetworkBroadcastChannelRegistry.cpp
M Source/WebKit/NetworkProcess/NetworkProcess.cpp
M Source/WebKit/NetworkProcess/NetworkProcess.h
M Source/WebKit/NetworkProcess/Notifications/NetworkNotificationManager.cpp
M
Source/WebKit/NetworkProcess/SharedWorker/WebSharedWorkerServerConnection.cpp
Log Message:
-----------
fix potential lifetime issues retrieving sharedpreferences
https://bugs.webkit.org/show_bug.cgi?id=296444
rdar://problem/156628694
Reviewed by Sihui Liu.
Potential lifetime issue when accessing
webProcessConnection->sharedPreferencesForWebProcess() as webProcessConnection
could be null, fixed this by holding references correctly
* Source/WebKit/NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::protectedWebProcessConnection const):
* Source/WebKit/NetworkProcess/NetworkProcess.h:
* Source/WebKit/NetworkProcess/Notifications/NetworkNotificationManager.cpp:
(WebKit::NetworkNotificationManager::sharedPreferencesForWebProcess const):
* Source/WebKit/NetworkProcess/SharedWorker/WebSharedWorkerServerConnection.cpp:
(WebKit::WebSharedWorkerServerConnection::sharedPreferencesForWebProcess const):
Originally-landed-as: 297297.328@safari-7622-branch (cb36c0c6b490).
rdar://164279694
Canonical link: https://commits.webkit.org/303306@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications