Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c8f041d5cf9682acc5e2f392b93c54f853d7b71c
      
https://github.com/WebKit/WebKit/commit/c8f041d5cf9682acc5e2f392b93c54f853d7b71c
  Author: Alan Baradlay <[email protected]>
  Date:   2025-11-25 (Tue, 25 Nov 2025)

  Changed paths:
    M 
Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp
    M Source/WebCore/layout/formattingContexts/inline/InlineFormattingUtils.cpp
    M Source/WebCore/layout/formattingContexts/inline/InlineFormattingUtils.h
    M Source/WebCore/layout/formattingContexts/inline/InlineLine.cpp
    M Source/WebCore/layout/formattingContexts/inline/InlineLine.h
    M Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp
    M Source/WebCore/layout/formattingContexts/inline/RangeBasedLineBuilder.cpp
    M 
Source/WebCore/layout/formattingContexts/inline/TextOnlySimpleLineBuilder.cpp

  Log Message:
  -----------
  [cleanup] InlineFormattingUtils::horizontalAlignmentOffset should take a 
"isLastLineOrLineEndsWithForcedLineBreak" bool
https://bugs.webkit.org/show_bug.cgi?id=303069

Reviewed by Antti Koivisto.

Instead of passing in both the run list and a bool indicating if it is the last 
line,
let's pre-compute isLastLineOrLineEndsWithForcedLineBreak.

This is in preparation for supporting forced line breaks when initiated by 
block content
where the combination of "runs list + isLastLine" is not sufficient.

* Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::createDisplayContentForLineFromCachedContent):
* Source/WebCore/layout/formattingContexts/inline/InlineFormattingUtils.cpp:
(WebCore::Layout::InlineFormattingUtils::horizontalAlignmentOffset):
* Source/WebCore/layout/formattingContexts/inline/InlineFormattingUtils.h:
* Source/WebCore/layout/formattingContexts/inline/InlineLine.cpp:
(WebCore::Layout::Line::hasTrailingForcedLineBreak):
* Source/WebCore/layout/formattingContexts/inline/InlineLine.h:
* Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:
(WebCore::Layout::LineBuilder::layoutInlineContent):
* Source/WebCore/layout/formattingContexts/inline/RangeBasedLineBuilder.cpp:
(WebCore::Layout::RangeBasedLineBuilder::layoutInlineContent):
* Source/WebCore/layout/formattingContexts/inline/TextOnlySimpleLineBuilder.cpp:
(WebCore::Layout::TextOnlySimpleLineBuilder::layoutInlineContent):
(WebCore::Layout::TextOnlySimpleLineBuilder::placeSingleCharacterContentIfApplicable):

Canonical link: https://commits.webkit.org/303534@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications

Reply via email to