Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 1cc97586cd6badd248c988045800b3d695a23260
https://github.com/WebKit/WebKit/commit/1cc97586cd6badd248c988045800b3d695a23260
Author: Kimmo Kinnunen <[email protected]>
Date: 2025-12-02 (Tue, 02 Dec 2025)
Changed paths:
M Source/JavaScriptCore/API/OpaqueJSString.cpp
M Source/JavaScriptCore/API/OpaqueJSString.h
Log Message:
-----------
OpaqueJSString::tryCreate(String&&) omits isolatedCopy
https://bugs.webkit.org/show_bug.cgi?id=303299
rdar://165604488
Reviewed by Keith Miller.
As per the const String& constructor, OpaqueJSString intends to
hold an isolated copy of the string. Not all String&& are new strings,
so they need the isolatedCopy() call, too.
Remove const String& constructor, as that is redudundant when the
intention is to always adopt the parameter into a member. Use the
String&& constructor.
* Source/JavaScriptCore/API/OpaqueJSString.cpp:
(OpaqueJSString::tryCreate):
* Source/JavaScriptCore/API/OpaqueJSString.h:
(OpaqueJSString::OpaqueJSString):
Canonical link: https://commits.webkit.org/303743@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications