Title: [113765] trunk/Source/_javascript_Core
- Revision
- 113765
- Author
- da...@apple.com
- Date
- 2012-04-10 14:12:14 -0700 (Tue, 10 Apr 2012)
Log Message
Remove unused data member from Lexer class
https://bugs.webkit.org/show_bug.cgi?id=83429
Reviewed by Kentaro Hara.
I noticed that m_delimited was "write-only", so I deleted it.
* parser/Lexer.cpp:
(JSC::Lexer::setCode): Removed code to set m_delimited.
(JSC::Lexer::parseIdentifier): Ditto.
(JSC::Lexer::parseIdentifierSlowCase): Ditto.
(JSC::Lexer::lex): Ditto.
* parser/Lexer.h: Deleted m_delimited.
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (113764 => 113765)
--- trunk/Source/_javascript_Core/ChangeLog 2012-04-10 21:07:26 UTC (rev 113764)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-04-10 21:12:14 UTC (rev 113765)
@@ -1,3 +1,19 @@
+2012-04-10 Darin Adler <da...@apple.com>
+
+ Remove unused data member from Lexer class
+ https://bugs.webkit.org/show_bug.cgi?id=83429
+
+ Reviewed by Kentaro Hara.
+
+ I noticed that m_delimited was "write-only", so I deleted it.
+
+ * parser/Lexer.cpp:
+ (JSC::Lexer::setCode): Removed code to set m_delimited.
+ (JSC::Lexer::parseIdentifier): Ditto.
+ (JSC::Lexer::parseIdentifierSlowCase): Ditto.
+ (JSC::Lexer::lex): Ditto.
+ * parser/Lexer.h: Deleted m_delimited.
+
2012-04-10 Patrick Gansterer <par...@webkit.org>
[CMake] Enable USE_FOLDERS property
Modified: trunk/Source/_javascript_Core/parser/Lexer.cpp (113764 => 113765)
--- trunk/Source/_javascript_Core/parser/Lexer.cpp 2012-04-10 21:07:26 UTC (rev 113764)
+++ trunk/Source/_javascript_Core/parser/Lexer.cpp 2012-04-10 21:12:14 UTC (rev 113765)
@@ -403,7 +403,6 @@
m_arena = &arena->identifierArena();
m_lineNumber = source.firstLine();
- m_delimited = false;
m_lastToken = -1;
const StringImpl* sourceString = source.provider()->data();
@@ -665,8 +664,6 @@
} else
tokenData->ident = 0;
- m_delimited = false;
-
if (UNLIKELY((remaining < maxTokenLength) && !(lexerFlags & LexerFlagsIgnoreReservedWords))) {
ASSERT(shouldCreateIdentifier);
if (remaining < maxTokenLength) {
@@ -726,8 +723,6 @@
} else
tokenData->ident = 0;
- m_delimited = false;
-
if (UNLIKELY((remaining < maxTokenLength) && !(lexerFlags & LexerFlagsIgnoreReservedWords))) {
ASSERT(shouldCreateIdentifier);
if (remaining < maxTokenLength) {
@@ -794,8 +789,6 @@
} else
tokenData->ident = 0;
- m_delimited = false;
-
if (LIKELY(!bufferRequired && !(lexerFlags & LexerFlagsIgnoreReservedWords))) {
ASSERT(shouldCreateIdentifier);
// Keywords must not be recognized if there was an \uXXXX in the identifier.
@@ -1192,8 +1185,6 @@
if (UNLIKELY(m_current == -1))
return EOFTOK;
- m_delimited = false;
-
CharacterType type;
if (LIKELY(isLatin1(static_cast<T>(m_current))))
type = static_cast<CharacterType>(typesOfLatin1Characters[m_current]);
@@ -1425,7 +1416,6 @@
shift();
break;
case CharacterSemicolon:
- m_delimited = true;
shift();
token = SEMICOLON;
break;
@@ -1436,7 +1426,6 @@
break;
case CharacterCloseBrace:
tokenData->intValue = currentOffset();
- m_delimited = true;
shift();
token = CLOSEBRACE;
break;
@@ -1491,7 +1480,6 @@
goto returnError;
}
m_buffer8.resize(0);
- m_delimited = false;
break;
case CharacterQuote:
if (lexerFlags & LexerFlagsDontBuildStrings) {
@@ -1502,7 +1490,6 @@
goto returnError;
}
shift();
- m_delimited = false;
token = STRING;
break;
case CharacterIdentifierStart:
@@ -1545,7 +1532,6 @@
goto start;
token = SEMICOLON;
- m_delimited = true;
// Fall through into returnToken.
returnToken:
Modified: trunk/Source/_javascript_Core/parser/Lexer.h (113764 => 113765)
--- trunk/Source/_javascript_Core/parser/Lexer.h 2012-04-10 21:07:26 UTC (rev 113764)
+++ trunk/Source/_javascript_Core/parser/Lexer.h 2012-04-10 21:12:14 UTC (rev 113765)
@@ -171,7 +171,6 @@
Vector<LChar> m_buffer8;
Vector<UChar> m_buffer16;
bool m_terminator;
- bool m_delimited; // encountered delimiter like "'" and "}" on last run
int m_lastToken;
const SourceCode* m_source;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
