Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 58e7166b1ee06f7313cb7bb40adf56c41e4b7af7
https://github.com/WebKit/WebKit/commit/58e7166b1ee06f7313cb7bb40adf56c41e4b7af7
Author: Qianlang Chen <[email protected]>
Date: 2025-12-05 (Fri, 05 Dec 2025)
Changed paths:
M Source/WebCore/inspector/agents/InspectorAnimationAgent.cpp
M Source/WebCore/inspector/agents/InspectorAnimationAgent.h
Log Message:
-----------
Web Inspector: Workaround WebAnimation destroyed without notifying
InspectorAnimationAgent to unbind it
https://webkit.org/b/303435
rdar://165070731
Reviewed by Basuke Suzuki.
In contrast to our assumption in 302497@main, it is possible for
WebAnimation to be destroyed without notifying the InspectorAnimationAgent
to clean up its map entry. Thus, we can't use WeakRef and access its
.ptr() reliably in findAnimationId().
Ideally we should figure out why the agent was not notified about the
destruction in time. Though it should still be worthwhile to prevent
crashing while we investigate further. So, use WeakPtr instead for now
and filed https://webkit.org/b/303593 as the follow-up.
No new tests; no observable change in behavior.
* Source/WebCore/inspector/agents/InspectorAnimationAgent.cpp:
(WebCore::InspectorAnimationAgent::frameNavigated):
(WebCore::InspectorAnimationAgent::findAnimationId):
(WebCore::InspectorAnimationAgent::bindAnimation):
* Source/WebCore/inspector/agents/InspectorAnimationAgent.h:
Canonical link: https://commits.webkit.org/303994@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
