Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 1e412dbc637a1f6b37bcc3a099b121c3fe7a058d
https://github.com/WebKit/WebKit/commit/1e412dbc637a1f6b37bcc3a099b121c3fe7a058d
Author: Jer Noble <[email protected]>
Date: 2025-12-05 (Fri, 05 Dec 2025)
Changed paths:
M Source/WebKit/UIProcess/Cocoa/_WKCaptionStyleMenuController.h
M Source/WebKit/UIProcess/ios/WKActionSheetAssistant.mm
M Source/WebKit/UIProcess/ios/_WKCaptionStyleMenuControllerAVKit.mm
Log Message:
-----------
[iOS] Caption Style menu selected item does not update
rdar://165893506
https://bugs.webkit.org/show_bug.cgi?id=303609
Reviewed by Eric Carlson.
On iOS, a UIMenu is immutable once it's presented. To update
the selected state of a menu requires calling -updateVisibleMenu:
and returning a new UIMenu structure.
When a caption profile is selected, iterate over the presented UIMenu
structure and replace the previous captions style menu with a rebuilt
one.
* Source/WebKit/UIProcess/Cocoa/_WKCaptionStyleMenuController.h:
* Source/WebKit/UIProcess/ios/WKActionSheetAssistant.mm:
(-[WKActionSheetAssistant captionStyleMenu:didSelectProfile:]):
* Source/WebKit/UIProcess/ios/_WKCaptionStyleMenuControllerAVKit.mm:
(-[_WKCaptionStyleMenuControllerAVKit
legibleMenuController:didRequestCaptionPreviewForProfileID:]):
Canonical link: https://commits.webkit.org/304006@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
