Title: [113781] trunk/Source/WebCore
- Revision
- 113781
- Author
- p...@google.com
- Date
- 2012-04-10 15:36:48 -0700 (Tue, 10 Apr 2012)
Log Message
Remove unnecessary calls to RenderSVGShape::createShape()
https://bugs.webkit.org/show_bug.cgi?id=83598
Reviewed by Rob Buis.
RenderSVGShape::strokeContains contains calls to fall back to path stroke hit detection
in several cases (dashed strokes, for example). One of these cases, a check for isStyled,
is not needed and is always true for Ellipses, Circles, and Rects (all styled elements).
This change removes the check for isStyled.
No new tests as this only affects performance, not test results.
* rendering/svg/RenderSVGShape.cpp:
(WebCore::RenderSVGShape::strokeContains):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (113780 => 113781)
--- trunk/Source/WebCore/ChangeLog 2012-04-10 22:33:40 UTC (rev 113780)
+++ trunk/Source/WebCore/ChangeLog 2012-04-10 22:36:48 UTC (rev 113781)
@@ -1,3 +1,20 @@
+2012-04-10 Philip Rogers <p...@google.com>
+
+ Remove unnecessary calls to RenderSVGShape::createShape()
+ https://bugs.webkit.org/show_bug.cgi?id=83598
+
+ Reviewed by Rob Buis.
+
+ RenderSVGShape::strokeContains contains calls to fall back to path stroke hit detection
+ in several cases (dashed strokes, for example). One of these cases, a check for isStyled,
+ is not needed and is always true for Ellipses, Circles, and Rects (all styled elements).
+ This change removes the check for isStyled.
+
+ No new tests as this only affects performance, not test results.
+
+ * rendering/svg/RenderSVGShape.cpp:
+ (WebCore::RenderSVGShape::strokeContains):
+
2012-04-10 Dan Bernstein <m...@apple.com>
<rdar://problem/10912486> CanvasRenderingContext2D does not expose its backing store resolution
Modified: trunk/Source/WebCore/rendering/svg/RenderSVGShape.cpp (113780 => 113781)
--- trunk/Source/WebCore/rendering/svg/RenderSVGShape.cpp 2012-04-10 22:33:40 UTC (rev 113780)
+++ trunk/Source/WebCore/rendering/svg/RenderSVGShape.cpp 2012-04-10 22:36:48 UTC (rev 113781)
@@ -152,7 +152,7 @@
}
if (!svgStyle->strokeDashArray().isEmpty() || svgStyle->strokeMiterLimit() != svgStyle->initialStrokeMiterLimit()
- || svgStyle->joinStyle() != svgStyle->initialJoinStyle() || svgStyle->capStyle() != svgStyle->initialCapStyle() || static_cast<SVGElement*>(node())->isStyled()) {
+ || svgStyle->joinStyle() != svgStyle->initialJoinStyle() || svgStyle->capStyle() != svgStyle->initialCapStyle()) {
if (!m_path)
RenderSVGShape::createShape();
return RenderSVGShape::shapeDependentStrokeContains(point);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
