Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 817c0e6ac4365d2f40747aa5ec6a4fad106a9663
https://github.com/WebKit/WebKit/commit/817c0e6ac4365d2f40747aa5ec6a4fad106a9663
Author: Phinehas Fuachie <[email protected]>
Date: 2025-12-08 (Mon, 08 Dec 2025)
Changed paths:
M Source/WebKit/UIProcess/ios/WKActionSheetAssistant.mm
M Source/WebKit/UIProcess/ios/_WKCaptionStyleMenuControllerIOS.mm
Log Message:
-----------
TestWebKitAPI.CaptionPreferenceTests.CaptionStyleMenu tests are broken
https://bugs.webkit.org/show_bug.cgi?id=303657
rdar://165741859
Reviewed by Aditya Keerthi.
Make menuController an autoreleased object when
HAVE_AVLEGIBLEMEDIAOPTIONSMENUCONTROLLER is
available for iOS. Remove adoptNS from m_styleMenuController assignment since
menuController
returns an autoreleased object, preventing overrelease.
* Source/WebKit/UIProcess/ios/WKActionSheetAssistant.mm:
(-[WKActionSheetAssistant
showMediaControlsContextMenu:items:frameInfo:identifier:completionHandler:]):
(-[WKActionSheetAssistant
showCaptionDisplaySettingsMenu:withOptions:completionHandler:]):
* Source/WebKit/UIProcess/ios/_WKCaptionStyleMenuControllerIOS.mm:
(+[WKCaptionStyleMenuController menuController]):
* Tools/TestWebKitAPI/Tests/WebCore/cocoa/CaptionPreferencesTests.mm:
(TestWebKitAPI::CaptionPreferenceTests::ensureController):
Canonical link: https://commits.webkit.org/304128@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
