Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: a979a88aadf788eccd523d5ad9c25287114c862b
https://github.com/WebKit/WebKit/commit/a979a88aadf788eccd523d5ad9c25287114c862b
Author: Chris Dumez <[email protected]>
Date: 2025-12-08 (Mon, 08 Dec 2025)
Changed paths:
M Source/WebCore/Modules/speech/SpeechSynthesis.cpp
M Source/WebCore/Modules/speech/SpeechSynthesisUtterance.cpp
M Source/WebCore/Modules/speech/SpeechSynthesisUtterance.h
M Source/WebCore/platform/PlatformSpeechSynthesisUtterance.cpp
M Source/WebCore/platform/PlatformSpeechSynthesisUtterance.h
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/UIProcess/WebPageProxyInternals.h
Log Message:
-----------
Drop IsDeprecatedWeakRefSmartPointerException for
PlatformSpeechSynthesisUtteranceClient
https://bugs.webkit.org/show_bug.cgi?id=303724
Reviewed by Ryosuke Niwa.
Drop IsDeprecatedWeakRefSmartPointerException for
PlatformSpeechSynthesisUtteranceClient
by making it AbstractRefCounted. Also make it a true virtual interface with a
virtual
function that SpeechSynthesisUtterance calls instead of having
SpeechSynthesisUtterance
do an unsafe cast from PlatformSpeechSynthesisUtteranceClient to one of its
subclasses.
Finally, stop making WebPageProxy::Internals a client. It wasn't truly a client
or the
cast would have failed.
* Source/WebCore/Modules/speech/SpeechSynthesis.cpp:
(WebCore::SpeechSynthesis::boundaryEventOccurred):
* Source/WebCore/Modules/speech/SpeechSynthesisUtterance.cpp:
(WebCore::SpeechSynthesisUtterance::SpeechSynthesisUtterance):
(WebCore::SpeechSynthesisUtterance::~SpeechSynthesisUtterance): Deleted.
* Source/WebCore/Modules/speech/SpeechSynthesisUtterance.h:
* Source/WebCore/platform/PlatformSpeechSynthesisUtterance.cpp:
(WebCore::PlatformSpeechSynthesisUtterance::create):
(WebCore::PlatformSpeechSynthesisUtterance::PlatformSpeechSynthesisUtterance):
* Source/WebCore/platform/PlatformSpeechSynthesisUtterance.h:
(WebCore::PlatformSpeechSynthesisUtterance::client const):
(WebCore::PlatformSpeechSynthesisUtterance::setClient): Deleted.
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::speechSynthesisSpeak):
* Source/WebKit/UIProcess/WebPageProxyInternals.h:
Canonical link: https://commits.webkit.org/304136@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
