Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 43662ccbd5af77371233091757679bdb191aaf1e
https://github.com/WebKit/WebKit/commit/43662ccbd5af77371233091757679bdb191aaf1e
Author: Rob Buis <[email protected]>
Date: 2025-12-11 (Thu, 11 Dec 2025)
Changed paths:
A LayoutTests/fast/css/checkVisibility-no-renderer-crash-expected.txt
A LayoutTests/fast/css/checkVisibility-no-renderer-crash.html
M Source/WebCore/dom/Element.cpp
Log Message:
-----------
[WebKit][Main] [ef80f3f18e6df299] ASAN_SEGV |
WebCore::RenderView::zoomFactor; WebCore::Style::adjustValueForPageZoom;
WebCore::Style::computeNonCalcLengthDouble
https://bugs.webkit.org/show_bug.cgi?id=302379
Reviewed by Tim Nguyen.
In checkVisibility computedStyle is used, however this could use calc()
in the computed style determination, and this may crash if the document has
no RenderView associated.
We can avoid this problem by implementing rule 1 from the specification [1].
[1] https://drafts.csswg.org/cssom-view-1/#dom-element-checkvisibility
Test: fast/css/checkVisibility-no-renderer-crash.html
* LayoutTests/fast/css/checkVisibility-no-renderer-crash-expected.txt: Added.
* LayoutTests/fast/css/checkVisibility-no-renderer-crash.html: Added.
* Source/WebCore/dom/Element.cpp:
(WebCore::Element::checkVisibility):
Canonical link: https://commits.webkit.org/304319@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
