Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: a523c7bf08138ebba37af0adeea5ea042dc6592d
https://github.com/WebKit/WebKit/commit/a523c7bf08138ebba37af0adeea5ea042dc6592d
Author: Geoffrey Garen <[email protected]>
Date: 2025-12-15 (Mon, 15 Dec 2025)
Changed paths:
M Source/WTF/wtf/ParkingLot.cpp
M Source/WTF/wtf/ParkingLot.h
M Tools/TestWebKitAPI/Tests/WTF/ParkingLot.cpp
Log Message:
-----------
(StabilityTracer: CloudTelemetryLocalBackendService at JavaScriptCore:
WTF::ParkingLot::parkConditionallyImpl)
https://bugs.webkit.org/show_bug.cgi?id=304215
rdar://165745990
Reviewed by Chris Dumez.
We have a circular dependency: Lock => ThreadData => Thread =>
ThreadSafeRefCountedAndCanMakeThreadSafeWeakPtr => Lock.
There are a lot of different ways we can fix this, but ultimately the dependency
only serves exactly one unit test, so let's just remove it and rework the test.
* Source/WTF/wtf/ParkingLot.cpp:
(WTF::ParkingLot::forEachImpl):
(WTF::ParkingLot::currentThreadID): Pass clients an unretained opaque identifier
for testing. This removes the dependency on Thread.
* Source/WTF/wtf/ParkingLot.h:
(WTF::ParkingLot::forEach):
* Tools/TestWebKitAPI/Tests/WTF/ParkingLot.cpp: Track an unretained opaque
identifier instead of a Thread* when testing.
Canonical link: https://commits.webkit.org/304494@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
