Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 3d9c90ebc3669040febf987073741484e32b436b
https://github.com/WebKit/WebKit/commit/3d9c90ebc3669040febf987073741484e32b436b
Author: Alan Baradlay <[email protected]>
Date: 2025-12-16 (Tue, 16 Dec 2025)
Changed paths:
M Source/WebCore/layout/integration/LayoutIntegrationBoxGeometryUpdater.cpp
M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp
M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.h
M Source/WebCore/rendering/RenderBlockFlow.cpp
Log Message:
-----------
[subpixel-inline-layout] Move RenderBlockFlow's "has line if empty" baseline
logic to LineLayout
https://bugs.webkit.org/show_bug.cgi?id=304124
Reviewed by Antti Koivisto.
IFC should handle all baseline logic when there's inline content. The remaining
"has line if empty" only applies to containers with no children (e.g.
<div></div>).
This is also in preparation for enabling subpixel inline layout.
(ascent/descent computation is now behind a runtime flag and hasLineIfEmpty
logic should consult this flag when computing baseline value.)
* Source/WebCore/layout/integration/LayoutIntegrationBoxGeometryUpdater.cpp:
(WebCore::LayoutIntegration::baselineForBox):
* Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::baselineForEmptyContent):
(WebCore::LayoutIntegration::LineLayout::firstLineBaseline const):
(WebCore::LayoutIntegration::LineLayout::lastLineBaseline const):
* Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.h:
* Source/WebCore/rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::firstLineBaseline const):
(WebCore::RenderBlockFlow::lastLineBaseline const):
Canonical link: https://commits.webkit.org/304523@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
