Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 9f04f384e3f352b1156bec82cc3b14fb9d76f716
https://github.com/WebKit/WebKit/commit/9f04f384e3f352b1156bec82cc3b14fb9d76f716
Author: Jonathan Bedard <[email protected]>
Date: 2025-12-16 (Tue, 16 Dec 2025)
Changed paths:
M Tools/Scripts/webkitpy/common/test_expectations_unittest.py
M Tools/Scripts/webkitpy/layout_tests/controllers/manager.py
M Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py
M Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py
M Tools/Scripts/webkitpy/layout_tests/views/printing_unittest.py
M Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py
M Tools/Scripts/webkitpy/port/apple.py
M Tools/Scripts/webkitpy/port/base.py
M Tools/Scripts/webkitpy/port/darwin.py
M Tools/Scripts/webkitpy/port/darwin_testcase.py
M Tools/Scripts/webkitpy/port/device_port.py
M Tools/Scripts/webkitpy/port/driver_unittest.py
M Tools/Scripts/webkitpy/port/factory.py
M Tools/Scripts/webkitpy/port/ios.py
M Tools/Scripts/webkitpy/port/ios_device_unittest.py
M Tools/Scripts/webkitpy/port/ios_simulator_unittest.py
M Tools/Scripts/webkitpy/port/ios_testcase.py
M Tools/Scripts/webkitpy/port/mac.py
M Tools/Scripts/webkitpy/port/mac_unittest.py
M Tools/Scripts/webkitpy/port/port_testcase.py
M Tools/Scripts/webkitpy/port/test.py
M Tools/Scripts/webkitpy/port/visionos.py
M Tools/Scripts/webkitpy/port/visionos_testcase.py
M Tools/Scripts/webkitpy/port/watch.py
M Tools/Scripts/webkitpy/port/watch_testcase.py
M Tools/Scripts/webkitpy/port/win.py
M Tools/Scripts/webkitpy/port/win_unittest.py
M Tools/Scripts/webkitpy/style/checkers/test_expectations.py
Log Message:
-----------
[run-webkit-tests] Add -2 option
rdar://165717647
https://bugs.webkit.org/show_bug.cgi?id=303418
Reviewed by Sam Sneddon.
Add a -2 option which forces ports to run with modern WebKit. Lay down
groundwork
for running with multiple drivers. Replace webkit_test_runner with the
driver_name variable,
and refactor various checks into parent port classes.
* Tools/Scripts/webkitpy/common/test_expectations_unittest.py:
* Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager.run): Check driver_name to determine if we're running under
WebKitLegacy.
* Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args): Add -2 option. Check that the user did not specify multiple
drivers.
(_set_up_derived_options): Remove special case for GTK and WPE.
* Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
Rebaseline.
* Tools/Scripts/webkitpy/layout_tests/views/printing_unittest.py: Ditto.
* Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner.__init__): Remove special case for GTK and WPE.
(PerfTestsRunner._parse_args): Add -2 option. Check that the user did not
specify multiple drivers.
* Tools/Scripts/webkitpy/port/apple.py:
(ApplePort.determine_full_port_name): Use driver check.
* Tools/Scripts/webkitpy/port/base.py:
(Port): Set driver names as a constant.
(Port.is_webkitlegacy): Check if the specified driver is a WebKitLegacy driver.
(Port.determine_full_port_name): Use driver check.
(Port.determine_driver_name): Centralize options to driver name conversions.
(Port.__init__): Check that the specified driver is supported for this port.
(Port.default_baseline_search_path): Use a driver check.
(Port.driver_name): Standardize driver check.
(Port._port_specific_expectations_files): Use a driver check.
(Port._build_driver): Ditto.
* Tools/Scripts/webkitpy/port/darwin.py:
(DarwinPort.__init__): Use modern `super()` call.
* Tools/Scripts/webkitpy/port/darwin_testcase.py:
(DarwinTest.assert_skipped_file_search_paths): Remove unused function.
* Tools/Scripts/webkitpy/port/device_port.py:
(DevicePort.driver_name): Convert driver name for Apple embedded platforms.
* Tools/Scripts/webkitpy/port/driver_unittest.py:
(DriverTest.test_no_timeout): Rebaseline.
* Tools/Scripts/webkitpy/port/factory.py:
(PortFactory.get): Never vend invalid ports.
* Tools/Scripts/webkitpy/port/ios.py:
(IOSPort): Support both WebKitTestRunner and DumpRenderTree.
(IOSPort.default_baseline_search_path): Use a driver check.
* Tools/Scripts/webkitpy/port/ios_device_unittest.py: Rebaseline.
* Tools/Scripts/webkitpy/port/ios_simulator_unittest.py: Rebaseline.
* Tools/Scripts/webkitpy/port/ios_testcase.py: Rebaseline.
* Tools/Scripts/webkitpy/port/mac.py:
(MacPort): Support both WebKitTestRunner and DumpRenderTree.
(MacPort.__init__): Use modern `super()` call.
(MacPort.default_baseline_search_path): Use a driver check.
(MacPort.default_child_processes): Remove special cases for WebKit.
* Tools/Scripts/webkitpy/port/mac_unittest.py: Rebaseline.
* Tools/Scripts/webkitpy/port/port_testcase.py: Rebaeline.
* Tools/Scripts/webkitpy/port/test.py: Support both WebKitTestRunner and
DumpRenderTree.
* Tools/Scripts/webkitpy/port/visionos.py:
(VisionOSPort.__init__): Deleted.
(VisionOSPort.driver_name): Deleted.
* Tools/Scripts/webkitpy/port/visionos_testcase.py:
(VisionOSTest.make_port): Remove special case.
* Tools/Scripts/webkitpy/port/watch.py:
(WatchPort.__init__): Deleted.
(WatchPort.driver_name): Deleted.
* Tools/Scripts/webkitpy/port/watch_testcase.py:
(WatchTest.make_port): Remove special case.
* Tools/Scripts/webkitpy/port/win.py:
(WinPort): Support both WebKitTestRunner and DumpRenderTree.
(WinPort.do_text_results_differ): Use a driver check.
(WinPort.driver_name): Convert driver name for Windows.
(WinPort._search_paths): Use a driver check.
* Tools/Scripts/webkitpy/port/win_unittest.py:
(WinPortTest._assert_search_path): Set driver.
(WinPortTest.test_compare_text): Rebaseline.
(WinPortTest.test_expectations_files): Rebaseline.
* Tools/Scripts/webkitpy/style/checkers/test_expectations.py:
(TestExpectationsChecker._determine_port_from_expectations_path): Handle ports
which
do not support WebKitLegacy.
Canonical link: https://commits.webkit.org/304573@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
