Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 1b30a1e2562ea05885f990a8921880ed91e7c4bc
https://github.com/WebKit/WebKit/commit/1b30a1e2562ea05885f990a8921880ed91e7c4bc
Author: Nipun Shukla <[email protected]>
Date: 2025-12-18 (Thu, 18 Dec 2025)
Changed paths:
A
LayoutTests/media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-liquid-glass-positioning-expected.txt
A
LayoutTests/media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-liquid-glass-positioning.html
M
Source/WebCore/Modules/modern-media-controls/controls/macos-inline-media-controls.js
M Source/WebCore/rendering/cocoa/RenderThemeCocoa.mm
Log Message:
-----------
[REGRESSION] globo.com: Buttons are squished on the video player
https://bugs.webkit.org/show_bug.cgi?id=304046
rdar://166073234
Reviewed by Andy Estes.
Hardcoded CSS left values and JavaScript absolute positioning (rightContainer.x)
overrode flexbox layout, preventing proper space distribution between button
containers. This caused buttons to overlap and appear squished instead of being
properly distributed by flexbox.
Changed CSS selectors from .left-cluster/.right-cluster to
.buttons-container.left/.buttons-container.right to match
structure. Removed JavaScript absolute positioning and hardcoded CSS
positioning that conflicted with flexbox layout. Added volume slider
container clearing to prevent JavaScript-set positions from overriding
CSS. This fixes button spacing and volume slider positioning issues
which made controls appear squished.
*
LayoutTests/media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-liquid-glass-positioning-expected.txt:
Added.
*
LayoutTests/media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-liquid-glass-positioning.html:
Added.
*
Source/WebCore/Modules/modern-media-controls/controls/macos-inline-media-controls.js:
(MacOSInlineMediaControls.prototype.layout):
* Source/WebCore/rendering/cocoa/RenderThemeCocoa.mm:
(WebCore::macOSInlineMediaControlsStyleSheet):
Canonical link: https://commits.webkit.org/304683@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
