Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: b0ee8b3d3d13294d495f8a87434c909262b5da15
https://github.com/WebKit/WebKit/commit/b0ee8b3d3d13294d495f8a87434c909262b5da15
Author: Nipun Shukla <[email protected]>
Date: 2025-12-18 (Thu, 18 Dec 2025)
Changed paths:
M Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp
M Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxyConfiguration.h
M
Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxyConfiguration.serialization.in
M Source/WebKit/Platform/cocoa/LayerHostingContextManager.h
M Source/WebKit/Platform/cocoa/LayerHostingContextManager.mm
M Source/WebKit/WebProcess/GPU/media/RemoteMediaPlayerManager.cpp
Log Message:
-----------
[Youtube Shorts] [PiP] Video turns blank while playing in PiP scrolling
through shorts
https://bugs.webkit.org/show_bug.cgi?id=303729
rdar://164577262
Reviewed by Jean-Yves Avenard.
When scrolling between YouTube Shorts in PiP, the video goes blank (audio
continues).
The bug occurs because videoLayerSize is derived from the platform layer's
frame,
which may be zero when the layer is created. Fix by restoring explicit
videoLayerSize
and preserving size across layer transitions instead of resetting it.
This problem seems to occur on a race when we have different resolutions/aspect
ratios
between videos being played. As such, this is quite difficult to test either
manually
or with layout tests.
* Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp:
(WebKit::RemoteMediaPlayerProxy::RemoteMediaPlayerProxy):
* Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxyConfiguration.h:
*
Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxyConfiguration.serialization.in:
* Source/WebKit/Platform/cocoa/LayerHostingContextManager.h:
* Source/WebKit/Platform/cocoa/LayerHostingContextManager.mm:
(WebKit::LayerHostingContextManager::setInitialVideoLayerSize):
(WebKit::LayerHostingContextManager::createHostingContextIfNeeded):
* Source/WebKit/WebProcess/GPU/media/RemoteMediaPlayerManager.cpp:
(WebKit::RemoteMediaPlayerManager::createRemoteMediaPlayer):
Canonical link: https://commits.webkit.org/304722@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
