Branch: refs/heads/webkitglib/2.50
Home: https://github.com/WebKit/WebKit
Commit: d148283508081c037235d63eb7a05f4348d77eb9
https://github.com/WebKit/WebKit/commit/d148283508081c037235d63eb7a05f4348d77eb9
Author: BJ Burg <[email protected]>
Date: 2025-12-19 (Fri, 19 Dec 2025)
Changed paths:
M Source/WebCore/inspector/agents/InspectorAnimationAgent.cpp
Log Message:
-----------
Cherry-pick 300761@main (d62af8e171ec).
https://bugs.webkit.org/show_bug.cgi?id=299490
Web Inspector: adopt more smart pointers in InspectorAnimationAgent
https://bugs.webkit.org/show_bug.cgi?id=299490
Reviewed by Devin Rousso.
* Source/WebCore/inspector/agents/InspectorAnimationAgent.cpp:
(WebCore::InspectorAnimationAgent::requestEffect):
(WebCore::InspectorAnimationAgent::requestEffectTarget):
(WebCore::InspectorAnimationAgent::resolveAnimation):
WebAnimations are refcounted, so keep strong references to them while
they are bound to animationIDs.
Canonical link: https://commits.webkit.org/300761@main
Canonical link: https://commits.webkit.org/298234.362@webkitglib/2.50
Commit: 4f9830521af977a66440fa5b4a714bb93b2aaae9
https://github.com/WebKit/WebKit/commit/4f9830521af977a66440fa5b4a714bb93b2aaae9
Author: BJ Burg <[email protected]>
Date: 2025-12-19 (Fri, 19 Dec 2025)
Changed paths:
M Source/WebCore/inspector/agents/InspectorAnimationAgent.cpp
M Source/WebCore/inspector/agents/InspectorAnimationAgent.h
Log Message:
-----------
Cherry-pick 302497@main (bb6619c24211).
https://bugs.webkit.org/show_bug.cgi?id=300926
Web Inspector: adopt more smart pointers in InspectorAnimationAgent (part 2)
https://bugs.webkit.org/show_bug.cgi?id=300926
Reviewed by Devin Rousso.
No new tests, no behavior change.
* Source/WebCore/inspector/agents/InspectorAnimationAgent.cpp:
(WebCore::InspectorAnimationAgent::resolveAnimation):
Do not resolve/bind an animation if its ScriptExecutionContext is gone.
(WebCore::InspectorAnimationAgent::findAnimationId):
(WebCore::InspectorAnimationAgent::bindAnimation):
* Source/WebCore/inspector/agents/InspectorAnimationAgent.h:
Use a WeakRef since we don't expect these references to become null.
We nonetheless should not extend the lifetime of the WebAnimation objects.
Canonical link: https://commits.webkit.org/302497@main
Canonical link: https://commits.webkit.org/298234.363@webkitglib/2.50
Commit: 2c9052001ba5cb0eb3bcbbde069db04f11f63be5
https://github.com/WebKit/WebKit/commit/2c9052001ba5cb0eb3bcbbde069db04f11f63be5
Author: Nipun Shukla <[email protected]>
Date: 2025-12-19 (Fri, 19 Dec 2025)
Changed paths:
A
LayoutTests/webanimations/simultaneous-animations-removed-separately-expected.txt
A LayoutTests/webanimations/simultaneous-animations-removed-separately.html
M Source/WebCore/animation/KeyframeEffect.cpp
M Source/WebCore/animation/WebAnimation.h
Log Message:
-----------
Cherry-pick 304710@main (42b3f8d91784).
https://bugs.webkit.org/show_bug.cgi?id=303217
REGRESSION (289928@main): Svelte transition fade + transition scale results
in flashing
https://bugs.webkit.org/show_bug.cgi?id=303217
rdar://165583864
Reviewed by Antoine Quint.
289928@main centralized effect stack membership updates but inadvertently
removed immediate stopping of accelerated animations when effects are
removed
from the stack. This patch restores that, preventing a visible flash. It
also
ensures that when animations are removed, they are allowed to finish before
removal.
*
LayoutTests/webanimations/simultaneous-animations-removed-separately-expected.txt:
Added.
*
LayoutTests/webanimations/simultaneous-animations-removed-separately.html:
Added.
* Source/WebCore/animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::wasRemovedFromEffectStack):
* Source/WebCore/animation/WebAnimation.h:
(WebCore::WebAnimation::hasPendingFinishNotification const):
Canonical link: https://commits.webkit.org/304710@main
Canonical link: https://commits.webkit.org/298234.364@webkitglib/2.50
Commit: b4beab021a4ab8f7fb101abd4e698b9fd35156f3
https://github.com/WebKit/WebKit/commit/b4beab021a4ab8f7fb101abd4e698b9fd35156f3
Author: Chris Dumez <[email protected]>
Date: 2025-12-19 (Fri, 19 Dec 2025)
Changed paths:
M Source/WebCore/workers/WorkerOrWorkletGlobalScope.cpp
M Source/WebCore/workers/WorkerOrWorkletGlobalScope.h
Log Message:
-----------
Cherry-pick 304727@main (5ab99ca27efb).
https://bugs.webkit.org/show_bug.cgi?id=304378
html/semantics/scripting-1/the-script-element/json-module/repeated-imports.any.sharedworker.html
is a flaky crash in debug
https://bugs.webkit.org/show_bug.cgi?id=304378
rdar://162879256
Reviewed by Sihui Liu.
Upon shared worker shutdown, when the shared worker is getting destroyed, we
see a `isContextThread()` check failing, even though we are on the shared
worker
thread. The issue is that `WorkerOrWorkletGlobalScope::m_thread->thread()`
is
null already by this point and so `isContextThread()` falls back to
checking if
we're on the main thread. To address the issue, we now store the UID of the
context thread on `WorkerOrWorkletGlobalScope` and simply check it in
`isContextThread()`, which should be a lot more reliable. This made the
crashes
go away for me locally.
No new tests, covered by
html/semantics/scripting-1/the-script-element/json-module/repeated-imports.any.sharedworker.html.
* Source/WebCore/workers/WorkerOrWorkletGlobalScope.cpp:
(WebCore::WorkerOrWorkletGlobalScope::WorkerOrWorkletGlobalScope):
(WebCore::WorkerOrWorkletGlobalScope::isContextThread const):
* Source/WebCore/workers/WorkerOrWorkletGlobalScope.h:
Canonical link: https://commits.webkit.org/304727@main
Canonical link: https://commits.webkit.org/298234.365@webkitglib/2.50
Compare: https://github.com/WebKit/WebKit/compare/a0990ac738d2...b4beab021a4a
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
