Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: b35ee7ad62e9d434f31e3cf9ba1a0590e2f5344d
https://github.com/WebKit/WebKit/commit/b35ee7ad62e9d434f31e3cf9ba1a0590e2f5344d
Author: Anuj Panta <[email protected]>
Date: 2025-12-19 (Fri, 19 Dec 2025)
Changed paths:
M Source/WebInspectorUI/UserInterface/Controllers/LayerTreeManager.js
Log Message:
-----------
Internal error in web inspector when viewing layers. Uncaught Exception:
TypeError: undefined is not an object (evaluating
'target.PageAgent.overrideSetting')
https://bugs.webkit.org/show_bug.cgi?id=304371
rdar://problem/166746536
Reviewed by BJ Burg.
The compositingBordersVisible setter loops through all targets without checking
if they support the Page domain. When a Worker or Frame target is present,
accessing target.PageAgent fails because PageAgent is undefined on non-Page
targets.
Believe to be introduced in 290243@main when removing iOS 12 compatibility
code. The
target.hasCommand("Page.overrideSetting") check was removed, which implicitly
verified the Page domain existed. The initializeTarget method correctly checks
target.hasDomain("Page") before accessing PageAgent; applying the same pattern
here.
* Source/WebInspectorUI/UserInterface/Controllers/LayerTreeManager.js:
(WI.LayerTreeManager.prototype.set compositingBordersVisible):
Canonical link: https://commits.webkit.org/304799@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
