Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 45d2ff003832f2f675276fc272a058934a0669d0
https://github.com/WebKit/WebKit/commit/45d2ff003832f2f675276fc272a058934a0669d0
Author: Ahmad Saleem <[email protected]>
Date: 2025-12-23 (Tue, 23 Dec 2025)
Changed paths:
M
LayoutTests/imported/w3c/web-platform-tests/svg/extensibility/foreignObject/containing-block-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/svg/extensibility/foreignObject/getboundingclientrect-expected.txt
M
LayoutTests/platform/glib/svg/custom/dominant-baseline-hanging-expected.txt
M LayoutTests/platform/ios/svg/custom/dominant-baseline-hanging-expected.txt
M LayoutTests/platform/mac/svg/custom/dominant-baseline-hanging-expected.txt
M LayoutTests/platform/win/svg/custom/dominant-baseline-hanging-expected.txt
M Source/WebCore/rendering/RenderBlock.cpp
Log Message:
-----------
[LegacySVG] Margin collapsing should not occur at the foreignObject boundary
https://bugs.webkit.org/show_bug.cgi?id=23963
rdar://97208795
Reviewed by Alan Baradlay.
This patch aligns WebKit with Gecko / Firefox and Blink / Chromium.
Merge:
https://chromium.googlesource.com/chromium/src.git/+/eb26f063d73fce4d8a2cf64541667e0863cb6421
This patch makes foreignObject a block formatting context (BFC) which
prevents margin collapsing across the foreignObject boundary. This
function (createsNewFormattingContext) is limited to BFC context nowadays.
https://svgwg.org/svg2-draft/single-page.html#embedded-ForeignObjectElement
* Source/WebCore/rendering/RenderBlock.cpp:
(WebCore::RenderBlock::createsNewFormattingContext const):
* LayoutTests/platform/glib/svg/custom/dominant-baseline-hanging-expected.txt:
* LayoutTests/platform/ios/svg/custom/dominant-baseline-hanging-expected.txt:
* LayoutTests/platform/mac/svg/custom/dominant-baseline-hanging-expected.txt:
* LayoutTests/platform/win/svg/custom/dominant-baseline-hanging-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/svg/extensibility/foreignObject/containing-block-expected.txt:
Progressions
*
LayoutTests/imported/w3c/web-platform-tests/svg/extensibility/foreignObject/getboundingclientrect-expected.txt:
Progressions
Canonical link: https://commits.webkit.org/304916@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
