Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: bda153efaee1cfabc72f28b67690ebfeeb8a3e90
https://github.com/WebKit/WebKit/commit/bda153efaee1cfabc72f28b67690ebfeeb8a3e90
Author: Ahmad Saleem <[email protected]>
Date: 2026-01-02 (Fri, 02 Jan 2026)
Changed paths:
A LayoutTests/svg/masking/mask-with-visibility-hidden-group-expected.html
A LayoutTests/svg/masking/mask-with-visibility-hidden-group.html
M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResourceMasker.cpp
Log Message:
-----------
[LegacySVG] Don't check 'visibility' in LegacyRenderSVGResourceMasker
https://bugs.webkit.org/show_bug.cgi?id=297045
rdar://157729389
Reviewed by Nikolas Zimmermann.
This patch aligns WebKit with Gecko / Firefox and Blink / Chromium. Note,
this bug does not exist in Layer Based SVG engine (LBSE).
Merge:
https://chromium.googlesource.com/chromium/src/+/51a75fa55ba71462963ddcf085995cf3eca66104
Since 'visibility' does not work in the same way as 'display', it's not
possible to "prune" subtrees based on non-'visible' values of the
property. Remove the check from the two methods that use it, and leave
to lower levels to handle it.
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResourceMasker.cpp:
(WebCore::LegacyRenderSVGResourceMasker::drawContentIntoContext):
(WebCore::LegacyRenderSVGResourceMasker::calculateMaskContentRepaintRect):
* LayoutTests/svg/masking/mask-with-visibility-hidden-group-expected.html:
Added.
* LayoutTests/svg/masking/mask-with-visibility-hidden-group.html: Added.
Canonical link: https://commits.webkit.org/305047@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
