Title: [113910] trunk/LayoutTests
Revision
113910
Author
[email protected]
Date
2012-04-11 14:27:21 -0700 (Wed, 11 Apr 2012)

Log Message

All Mac bots occasionally fail tons of media/ sputnik/ and svg/ tests
https://bugs.webkit.org/show_bug.cgi?id=83411

Reviewed by Eric Carlson.
Patch by Antonio Gomes <[email protected]>

Fix obvious problems with the test in order to make tests lets
flaky.

* media/nodesFromRect-shadowContent.html:
* platform/gtk/media/nodesFromRect-shadowContent-expected.txt:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (113909 => 113910)


--- trunk/LayoutTests/ChangeLog	2012-04-11 21:07:47 UTC (rev 113909)
+++ trunk/LayoutTests/ChangeLog	2012-04-11 21:27:21 UTC (rev 113910)
@@ -1,3 +1,15 @@
+2012-04-10  Antonio Gomes  <[email protected]>
+
+        All Mac bots occasionally fail tons of media/ sputnik/ and svg/ tests
+        https://bugs.webkit.org/show_bug.cgi?id=83411
+
+        Reviewed by Eric Carlson.
+
+        Fix obvious problems with the test in order to make tests lets flaky.
+
+        * media/nodesFromRect-shadowContent.html:
+        * platform/gtk/media/nodesFromRect-shadowContent-expected.txt:
+
 2012-04-11  Ryosuke Niwa  <[email protected]>
 
         fast/dom/dom-parse-serialize.html and dom-parse-serialize-display.html should be text tests

Modified: trunk/LayoutTests/media/nodesFromRect-shadowContent.html (113909 => 113910)


--- trunk/LayoutTests/media/nodesFromRect-shadowContent.html	2012-04-11 21:07:47 UTC (rev 113909)
+++ trunk/LayoutTests/media/nodesFromRect-shadowContent.html	2012-04-11 21:27:21 UTC (rev 113910)
@@ -13,11 +13,6 @@
   <script type="text/_javascript_" charset="utf-8">
     function runTest()
     {
-      if (window.layoutTestController) {
-        layoutTestController.dumpAsText();
-        layoutTestController.waitUntilDone();
-      }
-
       var e = {};
 
       // Set up shortcut access to elements
@@ -42,12 +37,7 @@
 
       var shadow =['-webkit-media-controls-timeline-container', '-webkit-media-controls-play-button', '-webkit-media-controls-panel', '-webkit-media-controls'];
       checkShadowContent(clickX, clickY, 10, 10, 20, 20, shadow);
-
-      if (window.layoutTestController)
-        layoutTestController.notifyDone();
     }
-
-    window._onload_ = runTest;
   </script>
 </head>
 <body id="body">
@@ -58,6 +48,7 @@
         testExpected("video.controls", null, '!=');
         waitForEvent('canplaythrough', function () {
             runTest();
+            endTest();
         } );
         video.src = "" "content/test");
     </script>

Modified: trunk/LayoutTests/platform/gtk/media/nodesFromRect-shadowContent-expected.txt (113909 => 113910)


--- trunk/LayoutTests/platform/gtk/media/nodesFromRect-shadowContent-expected.txt	2012-04-11 21:07:47 UTC (rev 113909)
+++ trunk/LayoutTests/platform/gtk/media/nodesFromRect-shadowContent-expected.txt	2012-04-11 21:27:21 UTC (rev 113910)
@@ -4,4 +4,5 @@
 
 EXPECTED (video.controls != 'null') OK
 EVENT(canplaythrough)
+END OF TEST
 

Modified: trunk/LayoutTests/platform/mac/Skipped (113909 => 113910)


--- trunk/LayoutTests/platform/mac/Skipped	2012-04-11 21:07:47 UTC (rev 113909)
+++ trunk/LayoutTests/platform/mac/Skipped	2012-04-11 21:27:21 UTC (rev 113910)
@@ -789,8 +789,5 @@
 # but not the innerWidth. The test passes on Qt, GTK and Chromium.
 fast/css/align-positioned-object-on-resize.html
 
-# https://bugs.webkit.org/show_bug.cgi?id=83411
-media/nodesFromRect-shadowContent.html
-
 # https://bugs.webkit.org/show_bug.cgi?id=83618
 fast/dom/inline-event-attributes-release.html
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to