Diff
Modified: trunk/LayoutTests/ChangeLog (113923 => 113924)
--- trunk/LayoutTests/ChangeLog 2012-04-11 23:28:30 UTC (rev 113923)
+++ trunk/LayoutTests/ChangeLog 2012-04-11 23:31:18 UTC (rev 113924)
@@ -1,3 +1,15 @@
+2012-04-11 Erik Arvidsson <[email protected]>
+
+ File API does not support DOM events (like addEventListener)
+ https://bugs.webkit.org/show_bug.cgi?id=83688
+
+ Reviewed by Adam Barth.
+
+ * fast/filesystem/resources/file-writer-events.js:
+ (runTest):
+ * fast/speech/scripted/basics-expected.txt:
+ * fast/speech/scripted/basics.html:
+
2012-04-11 Sheriff Bot <[email protected]>
Unreviewed, rolling out r113912.
Modified: trunk/LayoutTests/fast/filesystem/resources/file-writer-events.js (113923 => 113924)
--- trunk/LayoutTests/fast/filesystem/resources/file-writer-events.js 2012-04-11 23:28:30 UTC (rev 113923)
+++ trunk/LayoutTests/fast/filesystem/resources/file-writer-events.js 2012-04-11 23:31:18 UTC (rev 113924)
@@ -96,6 +96,9 @@
}
function runTest(unusedFileEntry, fileWriter) {
+ assert(typeof fileWriter.addEventListener === 'function');
+ assert(typeof fileWriter.removeEventListener === 'function');
+ assert(typeof fileWriter.dispatchEvent === 'function');
startWrite(fileWriter);
}
var jsTestIsAsync = true;
Modified: trunk/LayoutTests/fast/speech/scripted/basics-expected.txt (113923 => 113924)
--- trunk/LayoutTests/fast/speech/scripted/basics-expected.txt 2012-04-11 23:28:30 UTC (rev 113923)
+++ trunk/LayoutTests/fast/speech/scripted/basics-expected.txt 2012-04-11 23:31:18 UTC (rev 113924)
@@ -26,4 +26,7 @@
PASS 'onerror' in speechReco is true
PASS 'onstart' in speechReco is true
PASS 'onend' in speechReco is true
+PASS 'addEventListener' in speechReco is true
+PASS 'removeEventListener' in speechReco is true
+PASS 'dispatchEvent' in speechReco is true
Modified: trunk/LayoutTests/fast/speech/scripted/basics.html (113923 => 113924)
--- trunk/LayoutTests/fast/speech/scripted/basics.html 2012-04-11 23:28:30 UTC (rev 113923)
+++ trunk/LayoutTests/fast/speech/scripted/basics.html 2012-04-11 23:31:18 UTC (rev 113924)
@@ -36,6 +36,10 @@
shouldBeTrue("'onstart' in speechReco");
shouldBeTrue("'onend' in speechReco");
+ shouldBeTrue("'addEventListener' in speechReco");
+ shouldBeTrue("'removeEventListener' in speechReco");
+ shouldBeTrue("'dispatchEvent' in speechReco");
+
finishJSTest();
}
Modified: trunk/Source/WebCore/ChangeLog (113923 => 113924)
--- trunk/Source/WebCore/ChangeLog 2012-04-11 23:28:30 UTC (rev 113923)
+++ trunk/Source/WebCore/ChangeLog 2012-04-11 23:31:18 UTC (rev 113924)
@@ -1,3 +1,19 @@
+2012-04-11 Erik Arvidsson <[email protected]>
+
+ File API does not support DOM events (like addEventListener)
+ https://bugs.webkit.org/show_bug.cgi?id=83688
+
+ Reviewed by Adam Barth.
+
+ The IDL files where missing addEventListener, removeEventListener and dispatchEvent.
+
+ Tests: fast/filesystem/file-writer-events.html
+ fast/speech/scripted/basics.html
+
+ * Modules/filesystem/FileWriter.idl: Add missing methods.
+ * Modules/mediastream/LocalMediaStream.idl: This one gets its EventTarget from MediaStream.
+ * Modules/speech/SpeechRecognition.idl: Add missing methods.
+
2012-04-11 Andy Estes <[email protected]>
LayerFlushScheduler's run loop observer should have an autorelease pool.
Modified: trunk/Source/WebCore/Modules/filesystem/FileWriter.idl (113923 => 113924)
--- trunk/Source/WebCore/Modules/filesystem/FileWriter.idl 2012-04-11 23:28:30 UTC (rev 113923)
+++ trunk/Source/WebCore/Modules/filesystem/FileWriter.idl 2012-04-11 23:31:18 UTC (rev 113924)
@@ -60,5 +60,15 @@
attribute EventListener onabort;
attribute EventListener onerror;
attribute EventListener onwriteend;
+
+ // EventTarget interface
+ void addEventListener(in DOMString type,
+ in EventListener listener,
+ in [Optional] boolean useCapture);
+ void removeEventListener(in DOMString type,
+ in EventListener listener,
+ in [Optional] boolean useCapture);
+ boolean dispatchEvent(in Event evt)
+ raises(EventException);
};
}
Modified: trunk/Source/WebCore/Modules/mediastream/LocalMediaStream.idl (113923 => 113924)
--- trunk/Source/WebCore/Modules/mediastream/LocalMediaStream.idl 2012-04-11 23:28:30 UTC (rev 113923)
+++ trunk/Source/WebCore/Modules/mediastream/LocalMediaStream.idl 2012-04-11 23:31:18 UTC (rev 113924)
@@ -27,7 +27,6 @@
interface [
Conditional=MEDIA_STREAM,
JSGenerateToNativeObject,
- EventTarget,
JSGenerateToJSObject
] LocalMediaStream : MediaStream {
[ImplementedAs=stopFunction] void stop();
Modified: trunk/Source/WebCore/Modules/speech/SpeechRecognition.idl (113923 => 113924)
--- trunk/Source/WebCore/Modules/speech/SpeechRecognition.idl 2012-04-11 23:28:30 UTC (rev 113923)
+++ trunk/Source/WebCore/Modules/speech/SpeechRecognition.idl 2012-04-11 23:31:18 UTC (rev 113924)
@@ -51,5 +51,15 @@
attribute EventListener onerror;
attribute EventListener onstart;
attribute EventListener onend;
+
+ // EventTarget interface
+ void addEventListener(in DOMString type,
+ in EventListener listener,
+ in [Optional] boolean useCapture);
+ void removeEventListener(in DOMString type,
+ in EventListener listener,
+ in [Optional] boolean useCapture);
+ boolean dispatchEvent(in Event evt)
+ raises(EventException);
};
}
