Title: [113933] trunk
- Revision
- 113933
- Author
- [email protected]
- Date
- 2012-04-11 18:09:06 -0700 (Wed, 11 Apr 2012)
Log Message
Layout Test webaudio/* is flaky
https://bugs.webkit.org/show_bug.cgi?id=83624
Reviewed by Chris Rogers.
Source/WebCore:
No new tests; fixes webaudio/ layout tests.
A merge error led to an Mutex overunlock situation, which caused all future mutex trylock
attempts to fail, but only on Windows. Remove the extraneous mutex unlock().
* Modules/webaudio/AudioBufferSourceNode.cpp:
(WebCore::AudioBufferSourceNode::process):
LayoutTests:
Re-enable webaudio/ layout tests on chromium-win.
* platform/chromium/test_expectations.txt:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (113932 => 113933)
--- trunk/LayoutTests/ChangeLog 2012-04-12 01:02:34 UTC (rev 113932)
+++ trunk/LayoutTests/ChangeLog 2012-04-12 01:09:06 UTC (rev 113933)
@@ -1,3 +1,14 @@
+2012-04-11 Jer Noble <[email protected]>
+
+ Layout Test webaudio/* is flaky
+ https://bugs.webkit.org/show_bug.cgi?id=83624
+
+ Reviewed by Chris Rogers.
+
+ Re-enable webaudio/ layout tests on chromium-win.
+
+ * platform/chromium/test_expectations.txt:
+
2012-04-11 Erik Arvidsson <[email protected]>
Add support for [ArrayClass] and use that on NodeList
Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (113932 => 113933)
--- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-04-12 01:02:34 UTC (rev 113932)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-04-12 01:09:06 UTC (rev 113933)
@@ -3793,30 +3793,6 @@
BUGWK83503 LINUX DEBUG : plugins/inner-html-display-none.html = CRASH
-BUGWK83624 WIN : plugins/netscape-dom-access-and-reload.html = TEXT
-BUGWK83624 WIN : webaudio/audioparam-connect-audioratesignal.html = TEXT
-BUGWK83624 WIN : webaudio/audiobuffersource-multi-channels.html = AUDIO
-BUGWK83624 WIN : webaudio/audiobuffersource-playbackrate.html = AUDIO
-BUGWK83624 WIN : webaudio/audiobuffersource-playbackState.html = TEXT
-BUGWK83624 WIN : webaudio/audiobuffersource.html = AUDIO
-BUGWK83624 WIN : webaudio/audiochannelmerger-stereo.html = TEXT
-BUGWK83624 WIN : webaudio/audioparam-exponentialRampToValueAtTime.html = TEXT
-BUGWK83624 WIN : webaudio/audioparam-linearRampToValueAtTime.html = TEXT
-BUGWK83624 WIN : webaudio/audioparam-setTargetValueAtTime.html = TEXT
-BUGWK83624 WIN : webaudio/audioparam-setValueAtTime.html = TEXT
-BUGWK83624 WIN : webaudio/audioparam-setValueCurveAtTime.html = TEXT
-BUGWK83624 WIN RELEASE : webaudio/convolution-mono-mono.html = TEXT
-BUGWK83624 WIN : webaudio/delaynode-maxdelay.html = TEXT
-BUGWK83624 WIN : webaudio/delaynode-scheduling.html = TEXT
-BUGWK83624 WIN : webaudio/delaynode.html = TEXT
-BUGWK83624 WIN : webaudio/gain.html = AUDIO
-BUGWK83624 WIN : webaudio/mixing.html = AUDIO
-BUGWK83624 WIN : webaudio/note-grain-on-play.html = TEXT
-BUGWK83624 WIN : webaudio/note-grain-on-timing.html = TEXT
-BUGWK83624 WIN : webaudio/up-mixing-mono-51.html = AUDIO
-BUGWK83624 WIN : webaudio/up-mixing-mono-stereo.html = AUDIO
-BUGWK83624 WIN : webaudio/up-mixing-stereo-51.html = AUDIO
-
BUGWK83635 : fast/canvas/2d.backingStorePixelRatio.html = TIMEOUT
BUGWK83635 : platform/chromium/virtual/gpu/fast/canvas/2d.backingStorePixelRatio.html = TIMEOUT
Modified: trunk/Source/WebCore/ChangeLog (113932 => 113933)
--- trunk/Source/WebCore/ChangeLog 2012-04-12 01:02:34 UTC (rev 113932)
+++ trunk/Source/WebCore/ChangeLog 2012-04-12 01:09:06 UTC (rev 113933)
@@ -1,3 +1,18 @@
+2012-04-11 Jer Noble <[email protected]>
+
+ Layout Test webaudio/* is flaky
+ https://bugs.webkit.org/show_bug.cgi?id=83624
+
+ Reviewed by Chris Rogers.
+
+ No new tests; fixes webaudio/ layout tests.
+
+ A merge error led to an Mutex overunlock situation, which caused all future mutex trylock
+ attempts to fail, but only on Windows. Remove the extraneous mutex unlock().
+
+ * Modules/webaudio/AudioBufferSourceNode.cpp:
+ (WebCore::AudioBufferSourceNode::process):
+
2012-04-11 Levi Weintraub <[email protected]>
Correct pixel snapping error in RenderBox::pixelSnappedClientWidth/Height
Modified: trunk/Source/WebCore/Modules/webaudio/AudioBufferSourceNode.cpp (113932 => 113933)
--- trunk/Source/WebCore/Modules/webaudio/AudioBufferSourceNode.cpp 2012-04-12 01:02:34 UTC (rev 113932)
+++ trunk/Source/WebCore/Modules/webaudio/AudioBufferSourceNode.cpp 2012-04-12 01:09:06 UTC (rev 113933)
@@ -160,8 +160,6 @@
}
outputBus->clearSilentFlag();
-
- m_processLock.unlock();
} else {
// Too bad - the tryLock() failed. We must be in the middle of changing buffers and were already outputting silence anyway.
outputBus->zero();
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
