Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: b9c051f0d27475e4034c9da89219260e9a5581da
https://github.com/WebKit/WebKit/commit/b9c051f0d27475e4034c9da89219260e9a5581da
Author: Philippe Normand <[email protected]>
Date: 2026-01-12 (Mon, 12 Jan 2026)
Changed paths:
M Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp
M Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.h
M
Source/WebCore/Modules/mediastream/gstreamer/GStreamerPeerConnectionBackend.cpp
M
Source/WebCore/Modules/mediastream/gstreamer/GStreamerPeerConnectionBackend.h
Log Message:
-----------
[GStreamer][WebRTC] ASSERT when running
imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-addTcpIceCandidate.html
https://bugs.webkit.org/show_bug.cgi?id=304637
Reviewed by Xabier Rodriguez-Calvar.
Keep track of the SDP string without a= prefix in a String. The previous code
was assigning the
substring to a StringView, leading to an ASSERT when attempting to remove
spurious space characters
because the underlying string wasn't kept around. This is now also done for old
GStreamer runtimes.
Driving-by, remove the un-needed GStreamerIceCandidate wrapper and use
RTCIceCandidate directly.
* Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp:
(WebCore::GStreamerMediaEndpoint::addIceCandidate):
* Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.h:
*
Source/WebCore/Modules/mediastream/gstreamer/GStreamerPeerConnectionBackend.cpp:
(WebCore::GStreamerPeerConnectionBackend::doAddIceCandidate):
* Source/WebCore/Modules/mediastream/gstreamer/GStreamerPeerConnectionBackend.h:
Canonical link: https://commits.webkit.org/305450@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
