Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 8866362b83e1d730e8d38ca7f157e5050903a885
https://github.com/WebKit/WebKit/commit/8866362b83e1d730e8d38ca7f157e5050903a885
Author: Carlos Garcia Campos <[email protected]>
Date: 2026-01-14 (Wed, 14 Jan 2026)
Changed paths:
M LayoutTests/fast/backgrounds/background-clip-text-and-blend-mode.html
M
LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/background-clip-text-and-blend-mode.html
M LayoutTests/platform/glib/TestExpectations
M LayoutTests/platform/wpe/TestExpectations
M Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp
M Source/WebCore/platform/graphics/skia/GraphicsContextSkia.h
Log Message:
-----------
[Skia] Current compositing mode should always be restored in
endTransparencyLayer()
https://bugs.webkit.org/show_bug.cgi?id=305384
Reviewed by Nikolas Zimmermann and Adrian Perez de Castro.
We currently save the given compositing mode in beginTransparencyLayer()
when receiving composite operation and blend mode, but not when
receiving an opacity. This patch adds a private saveLayer(),
receiving both the compositing mode and the opacity that ensures the
same behavior in both, and restoreLayer() to restore the layer state.
Fixes: fast/backgrounds/background-clip-text-and-blend-mode.html
imported/w3c/web-platform-tests/css/css-backgrounds/background-clip-text-and-blend-mode.html
* LayoutTests/fast/backgrounds/background-clip-text-and-blend-mode.html:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/background-clip-text-and-blend-mode.html:
* LayoutTests/platform/glib/TestExpectations:
* LayoutTests/platform/wpe/TestExpectations:
* Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContextSkia::drawOutsetShadow):
(WebCore::GraphicsContextSkia::drawSkiaRect):
(WebCore::GraphicsContextSkia::saveLayer):
(WebCore::GraphicsContextSkia::restoreLayer):
(WebCore::GraphicsContextSkia::beginTransparencyLayer):
(WebCore::GraphicsContextSkia::endTransparencyLayer):
(WebCore::GraphicsContextSkia::fillRoundedRectImpl):
(WebCore::GraphicsContextSkia::drawSkiaText):
* Source/WebCore/platform/graphics/skia/GraphicsContextSkia.h:
Canonical link: https://commits.webkit.org/305570@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
