Title: [113971] trunk/Source/WebCore
Revision
113971
Author
[email protected]
Date
2012-04-12 07:13:49 -0700 (Thu, 12 Apr 2012)

Log Message

Web Inspector: annotate the rest of profiler front-end for closure compiler
https://bugs.webkit.org/show_bug.cgi?id=83781

All remaining Profiler front-end files are annotated for closure compiler.

Reviewed by Pavel Feldman.

* inspector/compile-front-end.py:
* inspector/front-end/CSSSelectorProfileView.js:
* inspector/front-end/HeapSnapshotProxy.js:
(WebInspector.HeapSnapshotWorkerWrapper):
(WebInspector.HeapSnapshotWorkerWrapper.prototype.postMessag):
(WebInspector.HeapSnapshotWorkerWrapper.prototype.terminate):
(WebInspector.HeapSnapshotWorker):
(WebInspector.HeapSnapshotProxyObject.prototype.callFactoryMethod):
(WebInspector.HeapSnapshotProxyObject.prototype.callMethod):
* inspector/front-end/HeapSnapshotWorkerDispatcher.js:
* inspector/front-end/TopDownProfileDataGridTree.js:
(WebInspector.TopDownProfileDataGridTree.prototype.exclude):
* inspector/front-end/externs.js:
(addEventListener):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (113970 => 113971)


--- trunk/Source/WebCore/ChangeLog	2012-04-12 13:39:54 UTC (rev 113970)
+++ trunk/Source/WebCore/ChangeLog	2012-04-12 14:13:49 UTC (rev 113971)
@@ -1,3 +1,27 @@
+2012-04-12  Yury Semikhatsky  <[email protected]>
+
+        Web Inspector: annotate the rest of profiler front-end for closure compiler
+        https://bugs.webkit.org/show_bug.cgi?id=83781
+
+        All remaining Profiler front-end files are annotated for closure compiler.
+
+        Reviewed by Pavel Feldman.
+
+        * inspector/compile-front-end.py:
+        * inspector/front-end/CSSSelectorProfileView.js:
+        * inspector/front-end/HeapSnapshotProxy.js:
+        (WebInspector.HeapSnapshotWorkerWrapper):
+        (WebInspector.HeapSnapshotWorkerWrapper.prototype.postMessag):
+        (WebInspector.HeapSnapshotWorkerWrapper.prototype.terminate):
+        (WebInspector.HeapSnapshotWorker):
+        (WebInspector.HeapSnapshotProxyObject.prototype.callFactoryMethod):
+        (WebInspector.HeapSnapshotProxyObject.prototype.callMethod):
+        * inspector/front-end/HeapSnapshotWorkerDispatcher.js:
+        * inspector/front-end/TopDownProfileDataGridTree.js:
+        (WebInspector.TopDownProfileDataGridTree.prototype.exclude):
+        * inspector/front-end/externs.js:
+        (addEventListener):
+
 2012-04-12  Sam D  <[email protected]>
 
         Web Inspector: Node Value should not get corrupt while jump over different matches in search.

Modified: trunk/Source/WebCore/inspector/compile-front-end.py (113970 => 113971)


--- trunk/Source/WebCore/inspector/compile-front-end.py	2012-04-12 13:39:54 UTC (rev 113970)
+++ trunk/Source/WebCore/inspector/compile-front-end.py	2012-04-12 14:13:49 UTC (rev 113971)
@@ -277,6 +277,7 @@
         "dependencies": ["components"],
         "sources": [
             "BottomUpProfileDataGridTree.js",
+            "CSSSelectorProfileView.js",
             "DetailedHeapshotView.js",
             "DetailedHeapshotGridNodes.js",
             "ProfileDataGridTree.js",
@@ -285,6 +286,9 @@
             "ProfileView.js",
             "TopDownProfileDataGridTree.js",
             "HeapSnapshot.js",
+            "HeapSnapshotProxy.js",
+            "HeapSnapshotWorker.js",
+            "HeapSnapshotWorkerDispatcher.js",
         ]
     },
 #    {
@@ -300,12 +304,6 @@
 
 # To be compiled...
 #
-# [Profiler]
-# CSSSelectorProfileView
-# HeapSnapshotProxy
-# HeapSnapshotWorker
-# HeapSnapshotWorkerDispatcher
-#
 # [Misc]
 # inspector
 # SettingsScreen

Modified: trunk/Source/WebCore/inspector/front-end/CSSSelectorProfileView.js (113970 => 113971)


--- trunk/Source/WebCore/inspector/front-end/CSSSelectorProfileView.js	2012-04-12 13:39:54 UTC (rev 113970)
+++ trunk/Source/WebCore/inspector/front-end/CSSSelectorProfileView.js	2012-04-12 14:13:49 UTC (rev 113971)
@@ -265,6 +265,7 @@
 
 /**
  * @constructor
+ * @extends {WebInspector.ProfileType}
  */
 WebInspector.CSSSelectorProfileType = function()
 {

Modified: trunk/Source/WebCore/inspector/front-end/HeapSnapshotProxy.js (113970 => 113971)


--- trunk/Source/WebCore/inspector/front-end/HeapSnapshotProxy.js	2012-04-12 13:39:54 UTC (rev 113970)
+++ trunk/Source/WebCore/inspector/front-end/HeapSnapshotProxy.js	2012-04-12 14:13:49 UTC (rev 113971)
@@ -28,6 +28,29 @@
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
+/**
+ * @constructor
+ * @extends {WebInspector.Object}
+ */
+WebInspector.HeapSnapshotWorkerWrapper = function()
+{
+}
+
+WebInspector.HeapSnapshotWorkerWrapper.prototype =  {
+    postMessage: function(message)
+    {
+    },
+    terminate: function()
+    {
+    }
+}
+
+WebInspector.HeapSnapshotWorkerWrapper.prototype.__proto__ = WebInspector.Object.prototype;
+
+/**
+ * @constructor
+ * @extends {WebInspector.HeapSnapshotWorkerWrapper}
+ */
 WebInspector.HeapSnapshotRealWorker = function()
 {
     this._worker = new Worker("HeapSnapshotWorker.js");
@@ -51,8 +74,12 @@
     }
 };
 
-WebInspector.HeapSnapshotRealWorker.prototype.__proto__ = WebInspector.Object.prototype;
+WebInspector.HeapSnapshotRealWorker.prototype.__proto__ = WebInspector.HeapSnapshotWorkerWrapper.prototype;
 
+/**
+ * @constructor
+ * @extends {WebInspector.HeapSnapshotWorkerWrapper}
+ */
 WebInspector.HeapSnapshotFakeWorker = function()
 {
     this._dispatcher = new WebInspector.HeapSnapshotWorkerDispatcher(window, this._postMessageFromWorker.bind(this));
@@ -84,8 +111,12 @@
     }
 };
 
-WebInspector.HeapSnapshotFakeWorker.prototype.__proto__ = WebInspector.Object.prototype;
+WebInspector.HeapSnapshotFakeWorker.prototype.__proto__ = WebInspector.HeapSnapshotWorkerWrapper.prototype;
 
+/**
+ * @constructor
+ * @extends {WebInspector.Object}
+ */
 WebInspector.HeapSnapshotWorker = function()
 {
     this._nextObjectId = 1;
@@ -94,7 +125,7 @@
     this._previousCallbacks = [];
     // There is no support for workers in Chromium DRT.
     this._worker = typeof InspectorTest === "undefined" ? new WebInspector.HeapSnapshotRealWorker() : new WebInspector.HeapSnapshotFakeWorker();
-    this._worker.addEventListener("message", this._messageReceived.bind(this), false);
+    this._worker.addEventListener("message", this._messageReceived, this);
 }
 
 WebInspector.HeapSnapshotWorker.prototype = {
@@ -210,6 +241,9 @@
 
 WebInspector.HeapSnapshotWorker.prototype.__proto__ = WebInspector.Object.prototype;
 
+/**
+ * @constructor
+ */
 WebInspector.HeapSnapshotProxyObject = function(worker, objectId)
 {
     this._worker = worker;
@@ -233,7 +267,10 @@
         this._worker.dispose();
     },
 
-    callFactoryMethod: function(callback, methodName, proxyConstructorName)
+    /**
+     * @param {...*} var_args
+     */
+    callFactoryMethod: function(callback, methodName, proxyConstructorName, var_args)
     {
         return this._callWorker("callFactoryMethod", Array.prototype.slice.call(arguments, 0));
     },
@@ -243,7 +280,10 @@
         return this._callWorker("callGetter", Array.prototype.slice.call(arguments, 0));
     },
 
-    callMethod: function(callback, methodName)
+    /**
+     * @param {...*} var_args
+     */
+    callMethod: function(callback, methodName, var_args)
     {
         return this._callWorker("callMethod", Array.prototype.slice.call(arguments, 0));
     },
@@ -253,6 +293,10 @@
     }
 };
 
+/**
+ * @constructor
+ * @extends {WebInspector.HeapSnapshotProxyObject}
+ */
 WebInspector.HeapSnapshotLoaderProxy = function(worker, objectId)
 {
     WebInspector.HeapSnapshotProxyObject.call(this, worker, objectId);
@@ -313,6 +357,10 @@
 
 WebInspector.HeapSnapshotLoaderProxy.prototype.__proto__ = WebInspector.HeapSnapshotProxyObject.prototype;
 
+/**
+ * @constructor
+ * @extends {WebInspector.HeapSnapshotProxyObject}
+ */
 WebInspector.HeapSnapshotProxy = function(worker, objectId)
 {
     WebInspector.HeapSnapshotProxyObject.call(this, worker, objectId);
@@ -423,6 +471,10 @@
 
 WebInspector.HeapSnapshotProxy.prototype.__proto__ = WebInspector.HeapSnapshotProxyObject.prototype;
 
+/**
+ * @constructor
+ * @extends {WebInspector.HeapSnapshotProxyObject}
+ */
 WebInspector.HeapSnapshotProviderProxy = function(worker, objectId)
 {
     WebInspector.HeapSnapshotProxyObject.call(this, worker, objectId);
@@ -447,6 +499,10 @@
 
 WebInspector.HeapSnapshotProviderProxy.prototype.__proto__ = WebInspector.HeapSnapshotProxyObject.prototype;
 
+/**
+ * @constructor
+ * @extends {WebInspector.HeapSnapshotProxyObject}
+ */
 WebInspector.HeapSnapshotPathFinderProxy = function(worker, objectId)
 {
     WebInspector.HeapSnapshotProxyObject.call(this, worker, objectId);
@@ -466,6 +522,10 @@
 
 WebInspector.HeapSnapshotPathFinderProxy.prototype.__proto__ = WebInspector.HeapSnapshotProxyObject.prototype;
 
+/**
+ * @constructor
+ * @extends {WebInspector.HeapSnapshotProxyObject}
+ */
 WebInspector.HeapSnapshotsDiffProxy = function(worker, objectId)
 {
     WebInspector.HeapSnapshotProxyObject.call(this, worker, objectId);

Modified: trunk/Source/WebCore/inspector/front-end/HeapSnapshotWorkerDispatcher.js (113970 => 113971)


--- trunk/Source/WebCore/inspector/front-end/HeapSnapshotWorkerDispatcher.js	2012-04-12 13:39:54 UTC (rev 113970)
+++ trunk/Source/WebCore/inspector/front-end/HeapSnapshotWorkerDispatcher.js	2012-04-12 14:13:49 UTC (rev 113971)
@@ -28,6 +28,9 @@
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
+/**
+ * @constructor
+ */
 WebInspector.HeapSnapshotWorkerDispatcher = function(globalObject, postMessage)
 {
     this._objects = [];

Modified: trunk/Source/WebCore/inspector/front-end/TopDownProfileDataGridTree.js (113970 => 113971)


--- trunk/Source/WebCore/inspector/front-end/TopDownProfileDataGridTree.js	2012-04-12 13:39:54 UTC (rev 113970)
+++ trunk/Source/WebCore/inspector/front-end/TopDownProfileDataGridTree.js	2012-04-12 14:13:49 UTC (rev 113971)
@@ -108,7 +108,7 @@
         var excludedCallUID = profileDataGrideNode.callUID;
 
         var any = /** @type{*} */this;
-        var node = /** @type{WebInspector.ProfileDataGridNode} */any;
+        var node = /** @type{WebInspector.TopDownProfileDataGridNode} */any;
         WebInspector.TopDownProfileDataGridNode.prototype._exclude.call(node, excludedCallUID);
 
         if (this.lastComparator)

Modified: trunk/Source/WebCore/inspector/front-end/externs.js (113970 => 113971)


--- trunk/Source/WebCore/inspector/front-end/externs.js	2012-04-12 13:39:54 UTC (rev 113970)
+++ trunk/Source/WebCore/inspector/front-end/externs.js	2012-04-12 14:13:49 UTC (rev 113971)
@@ -59,7 +59,16 @@
 
 /** @param {Element} element */
 window.getComputedStyle = function(element) {}
+/** @param {*} message */
+function postMessage(message) {}
 
+/**
+ * @param {string} eventName
+ * @param {Function} listener
+ * @param {boolean=} capturing
+ */
+function addEventListener(eventName, listener, capturing) {}
+
 /** @param {boolean=} onlyFirst */
 Array.prototype.remove = function(obj, onlyFirst) {}
 Array.prototype.keySet = function() {}
@@ -207,13 +216,4 @@
 WebInspector.SourceJavaScriptTokenizer = {}
 WebInspector.SourceJavaScriptTokenizer.Keywords = {}
 
-/** @constructor */
-WebInspector.CSSSelectorProfileType = function() {}
-/**
- * @constructor
- * @extends {WebInspector.Object}
- */
-WebInspector.HeapSnapshotWorker = function() {}
-WebInspector.HeapSnapshotWorker.prototype.createObject = function(type) {}
-WebInspector.HeapSnapshotWorker.prototype.startCheckingForLongRunningCalls = function() {}
-
+var InspectorTest = {}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to