Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: f4cfd452ee0aab227117c00fad86cc662ec5226d
https://github.com/WebKit/WebKit/commit/f4cfd452ee0aab227117c00fad86cc662ec5226d
Author: Brent Fulgham <[email protected]>
Date: 2026-01-14 (Wed, 14 Jan 2026)
Changed paths:
M Source/WebCore/page/Quirks.cpp
M Source/WebCore/page/Quirks.h
M Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm
M Source/WebKit/UIProcess/mac/WebPageProxyMac.mm
Log Message:
-----------
tiktok.com: [macOS] Please upgrade to the latest version of your browser -
message on upload
https://bugs.webkit.org/show_bug.cgi?id=305422
<rdar://problem/166837052>
Reviewed by Vitor Roriz.
The initial quirk from 293441@main stopped working when a global custom user
agent was
set for TikTok on macOS.
Investigating this issue led to the realization that we have the unfortunate
architecture
of two separate “Custom User Agent” values governing page loads and the
Navigator API
(see Bug 305420). One is called customUserAgent, and was the field we populated
when fixing
the iOS version of this bug. The other is customUserAgentAsSiteSpecificQuirks,
which is
used when the overall domain is given a custom user agent.
For now, let's apply the same fix to customUserAgentAsSiteSpecificQuirks (if it
exists) so
that whichever flavor of custom URL is in place, it is tweaked with the
necessary "like
Chrome/136" string.
* Source/WebCore/page/Quirks.cpp:
(WebCore::Quirks::needsCustomUserAgentOverride):
* Source/WebCore/page/Quirks.h:
* Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::effectiveContentModeAfterAdjustingPolicies):
* Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::effectiveContentModeAfterAdjustingPolicies):
* Source/WebKit/UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::effectiveContentModeAfterAdjustingPolicies):
Canonical link: https://commits.webkit.org/305598@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
