Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: c924ca68f9f3d3bc297c0f2195d3764153cda77d
https://github.com/WebKit/WebKit/commit/c924ca68f9f3d3bc297c0f2195d3764153cda77d
Author: Ryan Haddad <[email protected]>
Date: 2026-01-16 (Fri, 16 Jan 2026)
Changed paths:
M Tools/CISupport/ews-build/steps.py
Log Message:
-----------
[ews] JSC tests being retried even though failures were identified as
pre-existing via results-db check
https://bugs.webkit.org/show_bug.cgi?id=305400
rdar://168074955
Reviewed by Jonathan Bedard.
The filtering logic in RunJavaScriptCoreTests was running after
evaluateCommand()
had already been called by super().run(), causing retry steps to be added before
the filtering completed. By the time filtering finished and correctly identified
all failures as pre-existing, the retry steps had already been added.
* Tools/CISupport/ews-build/steps.py: Fix by moving the JSON parsing and
filtering logic
from run() to runCommand(), which is called before evaluateCommand(). This
follows the same
pattern already used by RunWebKitTests.
(RunJavaScriptCoreTests.run):
(RunJavaScriptCoreTests):
(RunJavaScriptCoreTests.runCommand):
Canonical link: https://commits.webkit.org/305714@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
