Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: fd556bc5bbf1f0bd480af1d4dd913c5d314c4633
https://github.com/WebKit/WebKit/commit/fd556bc5bbf1f0bd480af1d4dd913c5d314c4633
Author: Marcos Caceres <[email protected]>
Date: 2026-01-19 (Mon, 19 Jan 2026)
Changed paths:
M Source/WebKit/UIProcess/DigitalCredentials/WKDigitalCredentialsPicker.mm
M
Source/WebKit/WebProcess/DigitalCredentials/DigitalCredentialsCoordinator.cpp
M
Source/WebKit/WebProcess/DigitalCredentials/DigitalCredentialsCoordinator.h
Log Message:
-----------
Digital Credentials: improve c++ safeness
rdar://168427091
https://bugs.webkit.org/show_bug.cgi?id=305750
Reviewed by Anne van Kesteren.
Addresses some small c++ safeness issues in Digital Credentials code.
Relies on existing tests.
* Source/WebKit/UIProcess/DigitalCredentials/WKDigitalCredentialsPicker.mm:
(-[WKDigitalCredentialsPicker performRequest:]): missing adoptNS() wrapper.
*
Source/WebKit/WebProcess/DigitalCredentials/DigitalCredentialsCoordinator.cpp:
use std:exchange to clear m_rawRequests after passing it to the completion
handler. Was moving it then clearing it, which could lead to use-after-move
issues.
(WebKit::DigitalCredentialsCoordinator::provideRawDigitalCredentialRequests):
* Source/WebKit/WebProcess/DigitalCredentials/DigitalCredentialsCoordinator.h:
made explicit constructor private.
Canonical link: https://commits.webkit.org/305822@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
