Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 4383b18cfe5211cfa56946a873667620bdcd7a9a
https://github.com/WebKit/WebKit/commit/4383b18cfe5211cfa56946a873667620bdcd7a9a
Author: Jean Haberer <[email protected]>
Date: 2026-01-20 (Tue, 20 Jan 2026)
Changed paths:
M Source/WebCore/dom/DocumentImmersive.cpp
M Source/WebCore/dom/DocumentImmersive.h
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/UIProcess/WebPageProxy.h
Log Message:
-----------
Fix Immersive Model lifecycle issues
https://bugs.webkit.org/show_bug.cgi?id=305652
rdar://166174678
Reviewed by Etienne Segonzac.
Make sure the immersive state lifecycle follows the page's.
* Source/WebCore/dom/DocumentImmersive.h:
* Source/WebCore/dom/DocumentImmersive.cpp:
Break down exit method for readability.
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::commitProvisionalPage):
(WebKit::WebPageProxy::presentImmersiveElement):
(WebKit::WebPageProxy::dismissImmersiveElement):
(WebKit::WebPageProxy::presentImmersiveElement const): Deleted.
(WebKit::WebPageProxy::dismissImmersiveElement const): Deleted.
Since the IPC connection is closed, the dismissal signal from the web process
will not go through,
Thus we manually need to trigger a client immersive dismissal when it closes.
Canonical link: https://commits.webkit.org/305872@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
