Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 5ffa3f091bc6ad44e1455d24bdadd8f843356167
https://github.com/WebKit/WebKit/commit/5ffa3f091bc6ad44e1455d24bdadd8f843356167
Author: Tyler Wilcock <[email protected]>
Date: 2026-01-20 (Tue, 20 Jan 2026)
Changed paths:
A
LayoutTests/accessibility/hidden-elements-with-aria-attributes-expected.txt
A LayoutTests/accessibility/hidden-elements-with-aria-attributes.html
M LayoutTests/platform/ios/TestExpectations
M Source/WebCore/accessibility/AccessibilityObject.cpp
Log Message:
-----------
AX: `aria-controls` and `aria-expanded` keeps elements with `hidden`
attribute visible in Voice Over's Form Control menu
https://bugs.webkit.org/show_bug.cgi?id=300899
rdar://162783041
Reviewed by Joshua Hoffman.
Elements with the HTML hidden attribute were incorrectly appearing in
VoiceOver's Form Control rotor when they had certain ARIA attributes.
This happened because defaultObjectInclusion() only checked for
display:none on ancestor elements, not on the element itself. This commit
fixes that.
Test: accessibility/hidden-elements-with-aria-attributes.html
* LayoutTests/accessibility/hidden-elements-with-aria-attributes-expected.txt:
Added.
* LayoutTests/accessibility/hidden-elements-with-aria-attributes.html: Added.
* LayoutTests/platform/ios/TestExpectations:
* Source/WebCore/accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::defaultObjectInclusion const):
Canonical link: https://commits.webkit.org/305902@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
